Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 504253003: Replacing "tap" with "touch" in the Contextual Search UI. (Closed)

Created:
6 years, 3 months ago by pedro (no code reviews)
Modified:
6 years, 3 months ago
Reviewers:
Mathieu, Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing "tap" with "touch" in the Contextual Search UI. TBR=thestig BUG=407904 Committed: https://crrev.com/78e51a1e886c42d927c9e19329305b2dc2a4d94d Cr-Commit-Position: refs/heads/master@{#292105}

Patch Set 1 #

Patch Set 2 : Adding typographical quotes #

Patch Set 3 : Updating commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/chromium_strings.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
pedro (no code reviews)
pedrosimonetti@chromium.org changed reviewers: + mathp@chromium.org
6 years, 3 months ago (2014-08-27 00:23:04 UTC) #1
pedro (no code reviews)
Mathieu, please take a look at this change.
6 years, 3 months ago (2014-08-27 00:23:19 UTC) #2
Mathieu
On 2014/08/27 00:23:19, pedrosimonetti wrote: > Mathieu, please take a look at this change. Lgtm
6 years, 3 months ago (2014-08-27 00:55:27 UTC) #3
pedro (no code reviews)
On 2014/08/27 00:55:27, Mathieu Perreault wrote: > On 2014/08/27 00:23:19, pedrosimonetti wrote: > > Mathieu, ...
6 years, 3 months ago (2014-08-27 02:24:21 UTC) #4
Mathieu
On 2014/08/27 02:24:21, pedrosimonetti wrote: > On 2014/08/27 00:55:27, Mathieu Perreault wrote: > > On ...
6 years, 3 months ago (2014-08-27 02:46:59 UTC) #5
pedro (no code reviews)
pedrosimonetti@chromium.org changed reviewers: + jam@chromium.org
6 years, 3 months ago (2014-08-27 03:05:29 UTC) #6
pedro (no code reviews)
On 2014/08/27 03:05:29, pedrosimonetti wrote: > mailto:pedrosimonetti@chromium.org changed reviewers: > + mailto:jam@chromium.org jam@ please take ...
6 years, 3 months ago (2014-08-27 03:06:19 UTC) #7
pedro (no code reviews)
The CQ bit was checked by pedrosimonetti@chromium.org
6 years, 3 months ago (2014-08-27 03:53:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/504253003/20001
6 years, 3 months ago (2014-08-27 03:54:06 UTC) #9
pedro (no code reviews)
The CQ bit was unchecked by pedrosimonetti@chromium.org
6 years, 3 months ago (2014-08-27 03:54:20 UTC) #10
pedro (no code reviews)
pedrosimonetti@chromium.org changed reviewers: + thestig@chromium.org - jam@chromium.org
6 years, 3 months ago (2014-08-27 03:56:07 UTC) #11
pedro (no code reviews)
Handing it over to thestig@ instead since jam@ seems to be busy with code yellow.
6 years, 3 months ago (2014-08-27 03:56:41 UTC) #12
pedro (no code reviews)
thestig@: I'm TBR'ing this change because its a trivial string change that is blocking our ...
6 years, 3 months ago (2014-08-27 04:15:02 UTC) #13
pedro (no code reviews)
The CQ bit was checked by pedrosimonetti@chromium.org
6 years, 3 months ago (2014-08-27 04:15:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/504253003/40001
6 years, 3 months ago (2014-08-27 04:16:14 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 05:15:31 UTC) #16
Lei Zhang
lgtm stamp
6 years, 3 months ago (2014-08-27 05:50:07 UTC) #17
pedro (no code reviews)
Thanks for the quick stamp!
6 years, 3 months ago (2014-08-27 06:18:29 UTC) #18
pedro (no code reviews)
The CQ bit was unchecked by pedrosimonetti@chromium.org
6 years, 3 months ago (2014-08-27 06:18:41 UTC) #19
pedro (no code reviews)
The CQ bit was checked by pedrosimonetti@chromium.org
6 years, 3 months ago (2014-08-27 06:18:41 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/504253003/40001
6 years, 3 months ago (2014-08-27 06:18:49 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (40001) as 6e3993d45df978d0d4093d200b0216af56771e18
6 years, 3 months ago (2014-08-27 06:42:54 UTC) #22
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:49:59 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/78e51a1e886c42d927c9e19329305b2dc2a4d94d
Cr-Commit-Position: refs/heads/master@{#292105}

Powered by Google App Engine
This is Rietveld 408576698