|
|
Created:
6 years, 3 months ago by pedro (no code reviews) Modified:
6 years, 3 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionReplacing "tap" with "touch" in the Contextual Search UI.
TBR=thestig
BUG=407904
Committed: https://crrev.com/78e51a1e886c42d927c9e19329305b2dc2a4d94d
Cr-Commit-Position: refs/heads/master@{#292105}
Patch Set 1 #Patch Set 2 : Adding typographical quotes #Patch Set 3 : Updating commit message #
Messages
Total messages: 23 (0 generated)
pedrosimonetti@chromium.org changed reviewers: + mathp@chromium.org
Mathieu, please take a look at this change.
On 2014/08/27 00:23:19, pedrosimonetti wrote: > Mathieu, please take a look at this change. Lgtm
On 2014/08/27 00:55:27, Mathieu Perreault wrote: > On 2014/08/27 00:23:19, pedrosimonetti wrote: > > Mathieu, please take a look at this change. > > Lgtm Added typographical quotes and slightly changes the wording, as suggested by Newton in: https://chrome-internal-review.googlesource.com/#/c/174011/
On 2014/08/27 02:24:21, pedrosimonetti wrote: > On 2014/08/27 00:55:27, Mathieu Perreault wrote: > > On 2014/08/27 00:23:19, pedrosimonetti wrote: > > > Mathieu, please take a look at this change. > > > > Lgtm > > Added typographical quotes and slightly changes the wording, as suggested by > Newton in: > https://chrome-internal-review.googlesource.com/#/c/174011/ Perfect
pedrosimonetti@chromium.org changed reviewers: + jam@chromium.org
On 2014/08/27 03:05:29, pedrosimonetti wrote: > mailto:pedrosimonetti@chromium.org changed reviewers: > + mailto:jam@chromium.org jam@ please take a look at this change.
The CQ bit was checked by pedrosimonetti@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/504253003/...
The CQ bit was unchecked by pedrosimonetti@chromium.org
pedrosimonetti@chromium.org changed reviewers: + thestig@chromium.org - jam@chromium.org
Handing it over to thestig@ instead since jam@ seems to be busy with code yellow.
thestig@: I'm TBR'ing this change because its a trivial string change that is blocking our Android feature for M38.
The CQ bit was checked by pedrosimonetti@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/504253003/...
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
lgtm stamp
Thanks for the quick stamp!
The CQ bit was unchecked by pedrosimonetti@chromium.org
The CQ bit was checked by pedrosimonetti@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/504253003/...
Message was sent while issue was closed.
Committed patchset #3 (40001) as 6e3993d45df978d0d4093d200b0216af56771e18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/78e51a1e886c42d927c9e19329305b2dc2a4d94d Cr-Commit-Position: refs/heads/master@{#292105} |