Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 504253002: Revert of Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable. (Closed)

Created:
6 years, 3 months ago by jabdelmalek
Modified:
6 years, 3 months ago
Reviewers:
calamity, sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable. (patchset #1 of https://codereview.chromium.org/492623003/) Reason for revert: Causing huge amounts of flake even with retries, see these jobs that failed on the CQ. Please don't renable without watching the trybots closely to make sure it's not causing a lot of failures: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming?numbuilds=200 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5716 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5716 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5696 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5688 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5685 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5680 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5678 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5675 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5673 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5671 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5667 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5666 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5665 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5663 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5661 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5661 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5660 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5647 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5644 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5643 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5637 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5639 Original issue's description: > Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable. > > This test was flaky because it modified system properties. Moving it to > interactive_ui_tests should allow it the system control guarantees it > needs to complete successfully. > > BUG=396344 > > Committed: https://chromium.googlesource.com/chromium/src/+/4d5d5d700a104f5e6bec47a8891fc5a54a4f242b TBR=sky@chromium.org,calamity@chromium.org NOTREECHECKS=true NOTRY=true BUG=396344 Committed: https://crrev.com/fe0013537c9d2554a97a3e752f5d1dd417b5cf59 Cr-Commit-Position: refs/heads/master@{#291913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jabdelmalek
Created Revert of Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable.
6 years, 3 months ago (2014-08-26 15:59:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jabdelmalek@google.com/504253002/1
6 years, 3 months ago (2014-08-26 15:59:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as baccbdd27a1b66377e0e5b67aadddbfa2feb5624
6 years, 3 months ago (2014-08-26 16:00:22 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:43:10 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fe0013537c9d2554a97a3e752f5d1dd417b5cf59
Cr-Commit-Position: refs/heads/master@{#291913}

Powered by Google App Engine
This is Rietveld 408576698