Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: third_party/instrumented_libraries/fix_rpaths

Issue 50423003: Adds a flag "use_instrumented_libraries" and corresponding target with 2 simple libs (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/instrumented_libraries/fix_rpaths
===================================================================
--- third_party/instrumented_libraries/fix_rpaths (revision 0)
+++ third_party/instrumented_libraries/fix_rpaths (revision 0)
@@ -0,0 +1,21 @@
+#!/bin/bash
+# Copyright (c) 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
Nico 2013/11/02 00:05:02 (this one is ok as bash script for now for example
+# found in the LICENSE file.
+
+# Changes all RPATHs in a given directory from XORIGIN to $ORIGIN
Nico 2013/10/30 14:47:02 Why is this needed? Can't you set them to the righ
alextaran1 2013/10/30 16:08:54 No I can't. We need to export ..$ORIGIN.. to LDFLA
Alexander Potapenko 2013/10/31 12:18:16 Please explain this in a comment in download_build
alextaran1 2013/11/01 11:17:00 Done.
+
+# Fixes rpath from XORIGIN to $ORIGIN in a single file $1.
+function fix_rpath {
+ chrpath -r $(chrpath $1 | cut -d " " -f 2 | sed s/XORIGIN/\$ORIGIN/g \
+ | sed s/RPATH=//g) $1 > /dev/null
+}
+
+for i in $(find $1 | grep "\.so$"); do
+ fix_rpath $i
+done
+
+# Mark that rpaths are fixed.
+# This file is used by GYP as 'output' to mark that RPATHs are alreaty fixed
Nico 2013/10/30 14:47:02 typo alreaty
alextaran1 2013/10/30 16:08:54 Done.
+# while making incremental build.
Nico 2013/10/30 14:47:02 "for incremental builds"
alextaran1 2013/10/30 16:08:54 Done.
+touch $1/rpaths.fixed.txt
Property changes on: third_party/instrumented_libraries/fix_rpaths
___________________________________________________________________
Added: svn:executable
+ *

Powered by Google App Engine
This is Rietveld 408576698