Adds a flag "use_instrumented_libraries" and corresponding target with 2 simple libs

third_party/instrumented_libraries/instrumented_libraries.gyp

+# Copyright (c) 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'targets': [
+    {
+      'target_name': 'instrumented_libraries',
+      'type': 'none',
+      'variables': {
+         'prune_self_dependency': 1,

[Nico, 2013/10/30 14:47:02]

Do you need this?

[alextaran1, 2013/10/30 16:08:54]

cyclic dependency otherwise.

+      },
+      'dependencies': [
+        'libpng12-0',
+        'libxau6',
+      ],
+      'actions': [
+        {
+          'action_name': 'fix_rpaths',
+          'inputs': [
+            'fix_rpaths',
+          ],
+          'outputs': [
+            '<(PRODUCT_DIR)/instrumented_libraries/asan/rpaths.fixed.txt',

[Nico, 2013/10/30 14:47:02]

build outputs generally shouldn't be written into the source directory. Maybe
use <(INTERMEDIATE_DIR) instead?

[alextaran1, 2013/10/30 16:08:54]

Build outputs are actually "*.so" files and many other files after running "make
install". It depends on library, but GYP should determine: does it have the
library built or not. This file is used only to detect that it's not necessary
to download library once again and build it.

[Nico, 2013/11/02 00:05:02]

Sorry, <(PRODUCT_DIR) evaluates to a build directory. I'm not sure what I was
thinking here, ignore this comment.

+          ],
+          'action': ['./fix_rpaths', '<(PRODUCT_DIR)/instrumented_libraries/asan'],
+        },
+      ],
+    },
+    {
+      'target_name': 'libpng12-0',

[Nico, 2013/10/30 14:47:02]

Is the idea to have one target like this for every system library?

[alextaran1, 2013/10/30 16:08:54]

Yes.

[Nico, 2013/11/02 00:05:02]

Hm. What's the advantage of downloading binaries over checking in the source and
building these products then?

+      'type': 'none',
+      'dependencies=': [
+      ],
+      'actions': [
+        {
+          'action_name': '<(_target_name)',
+          'inputs': [
+            'download_build_install',
+          ],
+          'outputs': [
+            '<(PRODUCT_DIR)/instrumented_libraries/asan/<(_target_name).txt',
+          ],
+          'action': ['./download_build_install', '-i', '<(PRODUCT_DIR)', '-l', '<(_target_name)', '-m', '<(INTERMEDIATE_DIR)', '-s', 'asan'],

[Nico, 2013/11/02 00:05:02]

If you want to keep the download action, please move everything that's shared
between these wrapper targets into a gypi file and include that into every
target. It sounds like there are going to be many of them, so each of them
should be short.

+        },
+      ],
+    },
+    {
+      'target_name': 'libxau6',
+      'type': 'none',
+      'dependencies=': [
+      ],
+      'actions': [
+        {
+          'action_name': '<(_target_name)',
+          'inputs': [
+            'download_build_install',
+          ],
+          'outputs': [
+            '<(PRODUCT_DIR)/instrumented_libraries/asan/<(_target_name).txt',
+          ],
+          'action': ['./download_build_install', '-i', '<(PRODUCT_DIR)', '-l', '<(_target_name)', '-m', '<(INTERMEDIATE_DIR)', '-s', 'asan'],
+        },
+      ],
+    },
+  ],
+}