Given git hash, get SVN revision(if available) or Commit position.

Fix minor error in string formating while processing DEPS.

BUG=407662
NOTRY=true

Committed: https://crrev.com/e226c78e9fbd9a8c2051d0b0357b8e0e488b11cc
Cr-Commit-Position: refs/heads/master@{#292027}

[prasadv, 2014-08-26 16:35:11]

prasadv@chromium.org changed reviewers:
+ qyearsley@chromium.org

[qyearsley, 2014-08-26 16:39:15]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2014-08-26 16:39:21]

On 2014/08/26 16:35:11, prasadv wrote:

lgtm

[qyearsley, 2014-08-26 16:39:29]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2014-08-26 16:39:29]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2014-08-26 16:39:29]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2014-08-26 16:39:30]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2014-08-26 16:40:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/prasadv@chromium.org/504223003/1

[commit-bot: I haz the power, 2014-08-26 16:41:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 16:41:40]

Failed to commit the patch.

[prasadv, 2014-08-26 22:38:20]

This CL has two parts:
1. Fix minor error in string formating while processing DEPS.
2. Given git hash, get SVN revision(if available) or Commit position.

BUG=407662,407854
NOTRY=true

[qyearsley, 2014-08-26 22:42:34]

https://codereview.chromium.org/504223003/diff/20001/tools/auto_bisect/source...
File tools/auto_bisect/source_control.py (right):

https://codereview.chromium.org/504223003/diff/20001/tools/auto_bisect/source...
tools/auto_bisect/source_control.py:207: """Maps directly to the 'git svn
find-rev' command.
The name and description probably should be updated now --

It tries to find a SVN revision OR git number for the given git hash, right?

If "git svn find_rev <hash>" fails, then it runs
"git log --format=%b -1 origin/master <hash> and greps for Cr-Commit-Position",
right?

https://codereview.chromium.org/504223003/diff/20001/tools/auto_bisect/source...
tools/auto_bisect/source_control.py:210: revision: The git SHA1 to use.
Update docstring

https://codereview.chromium.org/504223003/diff/20001/tools/auto_bisect/source...
tools/auto_bisect/source_control.py:213: An integer changelist #, otherwise
None.
This is now going to be git number (aka git commit position) OR an SVN revision,
I think?

https://codereview.chromium.org/504223003/diff/20001/tools/auto_bisect/source...
tools/auto_bisect/source_control.py:234: return int(commit_reg.group('commit'))
This block is only executed when "git svn find-rev <git-hash>" fails, right?

[prasadv, 2014-08-26 23:07:30]

PTAL!

https://codereview.chromium.org/504223003/diff/20001/tools/auto_bisect/source...
File tools/auto_bisect/source_control.py (right):

https://codereview.chromium.org/504223003/diff/20001/tools/auto_bisect/source...
tools/auto_bisect/source_control.py:207: """Maps directly to the 'git svn
find-rev' command.
On 2014/08/26 22:42:34, qyearsley wrote:
> The name and description probably should be updated now --
> 
> It tries to find a SVN revision OR git number for the given git hash, right?
> 
> If "git svn find_rev <hash>" fails, then it runs
> "git log --format=%b -1 origin/master <hash> and greps for
Cr-Commit-Position",
> right?

Done.

https://codereview.chromium.org/504223003/diff/20001/tools/auto_bisect/source...
tools/auto_bisect/source_control.py:210: revision: The git SHA1 to use.
On 2014/08/26 22:42:34, qyearsley wrote:
> Update docstring

Done.

https://codereview.chromium.org/504223003/diff/20001/tools/auto_bisect/source...
tools/auto_bisect/source_control.py:213: An integer changelist #, otherwise
None.
On 2014/08/26 22:42:34, qyearsley wrote:
> This is now going to be git number (aka git commit position) OR an SVN
revision,
> I think?

Done.

https://codereview.chromium.org/504223003/diff/20001/tools/auto_bisect/source...
tools/auto_bisect/source_control.py:234: return int(commit_reg.group('commit'))
On 2014/08/26 22:42:34, qyearsley wrote:
> This block is only executed when "git svn find-rev <git-hash>" fails, right?

Yes, basically everything in this method should be replaced with a 
single command once crbug.com/407316 is resolved.

[qyearsley, 2014-08-26 23:09:37]

lgtm

[prasadv, 2014-08-26 23:13:26]

The CQ bit was checked by prasadv@chromium.org

[commit-bot: I haz the power, 2014-08-26 23:14:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/prasadv@chromium.org/504223003/40001

[commit-bot: I haz the power, 2014-08-26 23:32:15]

Committed patchset #3 (40001) as 368b4c5e87cca674811c762a835ac33d7ecaa0e3

[commit-bot: I haz the power, 2014-09-10 02:47:15]

Patchset 3 (id:??) landed as
https://crrev.com/e226c78e9fbd9a8c2051d0b0357b8e0e488b11cc
Cr-Commit-Position: refs/heads/master@{#292027}