Continue key propagation for extensions without any listeners to chrome.commands.onCommand.

chrome/browser/extensions/extension_keybinding_registry.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_keybinding_registry.h"
 
 #include "base/values.h"
 #include "chrome/browser/extensions/active_tab_permission_granter.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 216 matching lines @@
   return false;
 }
 
 bool ExtensionKeybindingRegistry::ExecuteCommands(
     const ui::Accelerator& accelerator,
     const std::string& extension_id) {
   EventTargets::iterator targets = event_targets_.find(accelerator);
   if (targets == event_targets_.end() || targets->second.empty())
     return false;
 
+  if (!extensions::EventRouter::Get(browser_context_)

[Finnur, 2014/08/27 11:28:31]

Be careful here: extension_id can be empty (see NotifyEventTargets above), and
I'm guessing that might cause this to return early, breaking some codepaths.

[David Tseng, 2014/08/27 16:34:22]

You're totally right; this broke the majority of the [global]commands tests.

+      ->ExtensionHasEventListener(
+            extension_id,
+            "commands.onCommand"))

[Finnur, 2014/08/27 11:28:31]

This string literal also appears on line 118, so a const might be warranted at
the top.

[David Tseng, 2014/08/27 16:34:22]

Done.

+    return false;
+

[Finnur, 2014/08/27 11:28:31]

I'd like to see tests added for this functionality, both for global and
non-global extension. Also would have been good to run this through the try
servers. I'll add a few bots, just to see what happens.

[David Tseng, 2014/08/27 16:34:22]

Working on some tests now; the existing tests appear to pass in patchset 2 (at
least locally on Chrome OS).

   bool executed = false;
   for (TargetList::const_iterator it = targets->second.begin();
        it != targets->second.end(); it++) {
     if (extension_id.empty() || it->first == extension_id) {
       CommandExecuted(it->first, it->second);
       executed = true;
     }
   }
 
   return executed;
 }
 
 }  // namespace extensions