Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 504183002: Remove dead code from LookupResult (Closed)

Created:
6 years, 3 months ago by Toon Verwaest
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove dead code from LookupResult BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23414

Patch Set 1 #

Patch Set 2 : More dead code #

Patch Set 3 : Explicitly pass "interceptor" as a flag to the mirror debugger #

Patch Set 4 : Fix test #

Patch Set 5 : Use default property details for INTERCEPTOR results #

Total comments: 1

Patch Set 6 : Reduce PropertyType in PropertyDetails from 3 to 2 bits #

Patch Set 7 : Install the LoadFastElementStub descriptor and addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -251 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M src/field-index.h View 1 1 chunk +0 lines, -1 line 0 comments Download
D src/field-index.cc View 1 1 chunk +0 lines, -23 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 3 chunks +4 lines, -7 lines 0 comments Download
M src/isolate.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/lookup.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/mirror-debugger.js View 1 2 3 4 5 6 3 chunks +6 lines, -7 lines 0 comments Download
M src/objects.cc View 1 2 3 chunks +1 line, -7 lines 0 comments Download
M src/objects-printer.cc View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M src/property.h View 9 chunks +5 lines, -143 lines 0 comments Download
M src/property.cc View 1 1 chunk +0 lines, -21 lines 0 comments Download
M src/property-details.h View 1 2 3 4 5 2 chunks +12 lines, -15 lines 0 comments Download
M src/runtime.cc View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
verwaest@chromium.org changed reviewers: + yangguo@chromium.org
6 years, 3 months ago (2014-08-26 14:56:37 UTC) #1
Toon Verwaest
PTAL
6 years, 3 months ago (2014-08-26 14:56:37 UTC) #2
Yang
LGTM, but I think calling it is_interceptor_ might be more accurate. https://codereview.chromium.org/504183002/diff/80001/src/hydrogen.cc File src/hydrogen.cc (right): ...
6 years, 3 months ago (2014-08-26 15:30:17 UTC) #3
Toon Verwaest
6 years, 3 months ago (2014-08-26 16:33:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #7 manually as 23414 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698