Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 504163002: Use an enum of Flags internally in CompilationInfo. (Closed)

Created:
6 years, 3 months ago by titzer
Modified:
6 years, 3 months ago
Reviewers:
Yang, bmeuer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use an enum of Flags internally in CompilationInfo. This is a first step in cleaning up CompilationInfo; a subsequent logical step would be to inline most is_* and Set* and Mark* calls so that most callers can use call info.SetFlag(CompilationInfo::kMyFlag), or at the very least, rename them all to be consistent with their enum flag names. R=yangguo@chromium.org, bmeuer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -115 lines) Patch
M src/compiler.h View 9 chunks +63 lines, -105 lines 0 comments Download
M src/compiler.cc View 5 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 3 months ago (2014-08-26 14:26:11 UTC) #1
Yang
On 2014/08/26 14:26:11, titzer wrote: lgtm.
6 years, 3 months ago (2014-08-26 14:31:32 UTC) #2
titzer
6 years, 3 months ago (2014-08-26 14:42:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698