Support Int32 representation for selected binary operations.

runtime/vm/intermediate_language.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
 #define VM_INTERMEDIATE_LANGUAGE_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
 #include "vm/handles_impl.h"
 #include "vm/locations.h"
 #include "vm/method_recognizer.h"
 #include "vm/object.h"
 #include "vm/parser.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, throw_on_javascript_int_overflow);
 
 class BitVector;
 class BlockEntryInstr;
+class BoxIntNInstr;
 class BufferFormatter;
 class CatchBlockEntryInstr;
 class ComparisonInstr;
 class Definition;
 class Environment;
 class FlowGraph;
 class FlowGraphBuilder;
 class FlowGraphCompiler;
 class FlowGraphVisitor;
 class Instruction;
 class LocalVariable;
 class ParsedFunction;
 class Range;
 class RangeAnalysis;
 class RangeBoundary;
+class UnboxIntNInstr;
 
 // CompileType describes type of the value produced by the definition.
 //
 // It captures the following properties:
 //    - whether value can potentially be null or it is definitely not null;
 //    - concrete class id of the value or kDynamicCid if unknown statically;
 //    - abstract super type of the value, concrete type of the value in runtime
 //      is guaranteed to be sub type of this type.
 //
 // Values of CompileType form a lattice with a None type as a bottom and a
@@ skipping 413 matching lines @@
   M(AllocateObject)                                                            \
   M(LoadField)                                                                 \
   M(LoadUntagged)                                                              \
   M(LoadClassId)                                                               \
   M(InstantiateType)                                                           \
   M(InstantiateTypeArguments)                                                  \
   M(AllocateContext)                                                           \
   M(AllocateUninitializedContext)                                              \
   M(CloneContext)                                                              \
   M(BinarySmiOp)                                                               \
+  M(BinaryInt32Op)                                                             \
   M(UnarySmiOp)                                                                \
   M(UnaryDoubleOp)                                                             \
   M(CheckStackOverflow)                                                        \
   M(SmiToDouble)                                                               \
+  M(Int32ToDouble)                                                             \
   M(DoubleToInteger)                                                           \
   M(DoubleToSmi)                                                               \
   M(DoubleToDouble)                                                            \
   M(DoubleToFloat)                                                             \
   M(FloatToDouble)                                                             \
   M(CheckClass)                                                                \
   M(CheckClassId)                                                              \
   M(CheckSmi)                                                                  \
   M(Constant)                                                                  \
   M(UnboxedConstant)                                                           \
@@ skipping 57 matching lines @@
   M(Float64x2ToFloat32x4)                                                      \
   M(Simd64x2Shuffle)                                                           \
   M(Float64x2ZeroArg)                                                          \
   M(Float64x2OneArg)                                                           \
   M(ExtractNthOutput)                                                          \
   M(BinaryUint32Op)                                                            \
   M(ShiftUint32Op)                                                             \
   M(UnaryUint32Op)                                                             \
   M(BoxUint32)                                                                 \
   M(UnboxUint32)                                                               \
+  M(BoxInt32)                                                                  \
+  M(UnboxInt32)                                                                \
   M(UnboxedIntConverter)                                                       \
 
 
 #define FORWARD_DECLARATION(type) class type##Instr;
 FOR_EACH_INSTRUCTION(FORWARD_DECLARATION)
 #undef FORWARD_DECLARATION
 
 
 // Functions required in all concrete instruction classes.
 #define DECLARE_INSTRUCTION(type)                                              \
@@ skipping 34 matching lines @@
 
   const ICData* GetICData(
       const ZoneGrowableArray<const ICData*>& ic_data_array) const;
 
   bool IsBlockEntry() { return (AsBlockEntry() != NULL); }
   virtual BlockEntryInstr* AsBlockEntry() { return NULL; }
 
   bool IsDefinition() { return (AsDefinition() != NULL); }
   virtual Definition* AsDefinition() { return NULL; }
 
+  virtual BoxIntNInstr* AsBoxIntN() { return NULL; }
+  virtual UnboxIntNInstr* AsUnboxIntN() { return NULL; }
+
   virtual intptr_t token_pos() const { return Scanner::kNoSourcePos; }
 
   virtual intptr_t InputCount() const = 0;
   virtual Value* InputAt(intptr_t i) const = 0;
   void SetInputAt(intptr_t i, Value* value) {
     ASSERT(value != NULL);
     value->set_instruction(this);
     value->set_use_index(i);
     RawSetInputAt(i, value);
   }
@@ skipping 275 matching lines @@
   friend class SmiToDoubleInstr;
   friend class DoubleToIntegerInstr;
   friend class BranchSimplifier;
   friend class BlockEntryInstr;
   friend class RelationalOpInstr;
   friend class EqualityCompareInstr;
   friend class TestCidsInstr;
   friend class BinaryUint32OpInstr;
   friend class UnaryUint32OpInstr;
   friend class ShiftUint32OpInstr;
+  friend class UnboxIntNInstr;
+  friend class UnboxInt32Instr;
   friend class UnboxUint32Instr;
+  friend class BinaryInt32OpInstr;
+  friend class UnboxedIntConverterInstr;
 
   virtual void RawSetInputAt(intptr_t i, Value* value) = 0;
 
   enum {
     kNoPlaceId = -1
   };
 
   intptr_t deopt_id_;
   intptr_t lifetime_position_;  // Position used by register allocator.
   Instruction* previous_;
@@ skipping 708 matching lines @@
   // Does this define a mint?
   bool IsMintDefinition() {
     return (Type()->ToCid() == kMintCid) ||
             IsBinaryMintOp() ||
             IsUnaryMintOp() ||
             IsShiftMintOp() ||
             IsBoxInteger() ||
             IsUnboxInteger();
   }
 
+  bool IsInt32Definition() {
+    return IsBinaryInt32Op() ||
+           IsBoxInt32() ||
+           IsUnboxInt32() ||
+           IsUnboxedIntConverter();
+  }
+
   // Compute compile type for this definition. It is safe to use this
   // approximation even before type propagator was run (e.g. during graph
   // building).
   virtual CompileType ComputeType() const {
     return CompileType::Dynamic();
   }
 
   // Update CompileType of the definition. Returns true if the type has changed.
   virtual bool RecomputeType() {
     return false;
@@ skipping 10 matching lines @@
       return true;
     }
 
     return false;
   }
 
   bool HasUses() const {
     return (input_use_list_ != NULL) || (env_use_list_ != NULL);
   }
   bool HasOnlyUse(Value* use) const;
+  bool HasOnlyInputUse(Value* use) const;
+
 
   Value* input_use_list() const { return input_use_list_; }
   void set_input_use_list(Value* head) { input_use_list_ = head; }
   intptr_t InputUseListLength() const {
     intptr_t length = 0;
     Value* use = input_use_list_;
     while (use != NULL) {
       length++;
       use = use->next_use();
     }
@@ skipping 738 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ConstantInstr);
 };
 
 
 // Merged ConstantInstr -> UnboxedXXX into UnboxedConstantInstr.
 // TODO(srdjan): Implemented currently for doubles only, should implement
 // for other unboxing instructions.
 class UnboxedConstantInstr : public ConstantInstr {
  public:
-  explicit UnboxedConstantInstr(const Object& value);
+  explicit UnboxedConstantInstr(const Object& value,
+                                Representation representation);
 
   virtual Representation representation() const {
-    return kUnboxedDouble;
+    return representation_;
   }
 
   // Either NULL or the address of the unboxed constant.
   uword constant_address() const { return constant_address_; }
 
   DECLARE_INSTRUCTION(UnboxedConstant)
 
  private:
+  const Representation representation_;
   uword constant_address_;  // Either NULL or points to the untagged constant.
 
   DISALLOW_COPY_AND_ASSIGN(UnboxedConstantInstr);
 };
 
 
 class AssertAssignableInstr : public TemplateDefinition<3> {
  public:
   AssertAssignableInstr(intptr_t token_pos,
                         Value* value,
@@ skipping 2218 matching lines @@
 
   virtual void InferRange(RangeAnalysis* analysis, Range* range);
 
   virtual bool AllowsCSE() const { return true; }
   virtual EffectSet Effects() const { return EffectSet::None(); }
   virtual EffectSet Dependencies() const { return EffectSet::None(); }
   virtual bool AttributesEqual(Instruction* other) const { return true; }
 
   virtual bool MayThrow() const { return false; }
 
+  virtual Definition* Canonicalize(FlowGraph* flow_graph);
+
  private:
   bool is_smi_;
 
   DISALLOW_COPY_AND_ASSIGN(BoxIntegerInstr);
 };
 
 
 class UnboxDoubleInstr : public TemplateDefinition<1> {
  public:
   UnboxDoubleInstr(Value* value, intptr_t deopt_id) {
@@ skipping 156 matching lines @@
   DECLARE_INSTRUCTION(UnboxInteger)
   virtual CompileType ComputeType() const;
 
   virtual bool AllowsCSE() const { return true; }
   virtual EffectSet Effects() const { return EffectSet::None(); }
   virtual EffectSet Dependencies() const { return EffectSet::None(); }
   virtual bool AttributesEqual(Instruction* other) const { return true; }
 
   virtual bool MayThrow() const { return false; }
 
+  virtual Definition* Canonicalize(FlowGraph* flow_graph);
+
  private:
   DISALLOW_COPY_AND_ASSIGN(UnboxIntegerInstr);
 };
 
 
 class MathUnaryInstr : public TemplateDefinition<1> {
  public:
   enum MathUnaryKind {
     kIllegal,
     kSin,
@@ skipping 2015 matching lines @@
   virtual void InferRange(RangeAnalysis* analysis, Range* range);
 
   virtual Definition* Canonicalize(FlowGraph* flow_graph);
 
   // Returns true if right is a non-zero Smi constant which absolute value is
   // a power of two.
   bool RightIsPowerOfTwoConstant() const;
 
   virtual bool MayThrow() const { return false; }
 
+  virtual intptr_t DeoptimizationTarget() const {
+    // Direct access since this instruction cannot deoptimize, and the deopt-id
+    // was inherited from another instruction that could deoptimize.
+    return deopt_id_;
+  }
+
  private:
   const Token::Kind op_kind_;
   bool overflow_;
   bool is_truncating_;
   const intptr_t token_pos_;
 
   DISALLOW_COPY_AND_ASSIGN(BinarySmiOpInstr);
 };
 
 
+class BinaryInt32OpInstr : public TemplateDefinition<2> {
+ public:
+  BinaryInt32OpInstr(Token::Kind op_kind,
+                     Value* left,
+                     Value* right,
+                     intptr_t deopt_id)
+      : op_kind_(op_kind),
+        overflow_(true),
+        is_truncating_(false) {
+    SetInputAt(0, left);
+    SetInputAt(1, right);
+    // Override generated deopt-id.
+    deopt_id_ = deopt_id;
+  }
+
+  static bool IsSupported(Token::Kind op, Value* left, Value* right) {
+#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_ARM)

[srdjan, 2014/08/27 16:17:13]

You could move this into intermediate_language_xxx.cc

[Vyacheslav Egorov (Google), 2014/08/28 20:48:37]

Agreed. However I did not for two reasons:

1) This is a very temporary solution, and it is priority for me to actually
remove this #ifdef.

2) It would cause me to duplicated this switch twice (ARM, IA32) and duplicate
return false twice (MIPS, ARM64).

+    switch (op) {
+      case Token::kADD:
+      case Token::kSUB:
+      case Token::kMUL:
+      case Token::kBIT_AND:
+      case Token::kBIT_OR:
+      case Token::kBIT_XOR:
+        return true;
+
+      case Token::kSHL:
+      case Token::kSHR:
+        return right->BindsToConstant();
+
+      default:
+        return false;
+    }
+#else
+    return false;
+#endif
+  }
+
+  Value* left() const { return inputs_[0]; }
+  Value* right() const { return inputs_[1]; }
+
+  Token::Kind op_kind() const { return op_kind_; }
+
+  void set_overflow(bool overflow) { overflow_ = overflow; }
+
+  void set_is_truncating(bool value) { is_truncating_ = value; }
+  bool IsTruncating() const { return is_truncating_ || !overflow_; }
+
+  void PrintTo(BufferFormatter* f) const;
+  virtual void PrintOperandsTo(BufferFormatter* f) const;
+
+  DECLARE_INSTRUCTION(BinaryInt32Op)
+  virtual CompileType ComputeType() const;
+
+  virtual bool CanDeoptimize() const;
+
+  virtual bool AllowsCSE() const { return true; }
+  virtual EffectSet Effects() const { return EffectSet::None(); }
+  virtual EffectSet Dependencies() const { return EffectSet::None(); }
+  virtual bool AttributesEqual(Instruction* other) const;
+
+  virtual void InferRange(RangeAnalysis* analysis, Range* range);
+
+  virtual Definition* Canonicalize(FlowGraph* flow_graph);
+
+  virtual Representation representation() const {
+    return kUnboxedInt32;
+  }
+
+  virtual Representation RequiredInputRepresentation(intptr_t idx) const {
+    ASSERT(idx == 0 || idx == 1);

[srdjan, 2014/08/27 16:17:13]

parentheses

[Vyacheslav Egorov (Google), 2014/08/28 20:48:37]

Done.

+    return kUnboxedInt32;
+  }
+
+  virtual intptr_t DeoptimizationTarget() const {
+    // Direct access since this instruction cannot deoptimize, and the deopt-id
+    // was inherited from another instruction that could deoptimize.
+    return deopt_id_;
+  }
+
+  virtual bool MayThrow() const { return false; }
+
+ private:
+  const Token::Kind op_kind_;
+  bool overflow_;
+  bool is_truncating_;
+
+  DISALLOW_COPY_AND_ASSIGN(BinaryInt32OpInstr);
+};
+
+
 // Handles both Smi operations: BIT_OR and NEGATE.
 class UnarySmiOpInstr : public TemplateDefinition<1> {
  public:
   UnarySmiOpInstr(Token::Kind op_kind,
                   Value* value,
                   intptr_t deopt_id)
       : op_kind_(op_kind) {
     ASSERT((op_kind == Token::kNEGATE) || (op_kind == Token::kBIT_NOT));
     SetInputAt(0, value);
     // Override generated deopt-id.
@@ skipping 100 matching lines @@
   virtual void PrintOperandsTo(BufferFormatter* f) const;
 
  private:
   const intptr_t token_pos_;
   const intptr_t loop_depth_;
 
   DISALLOW_COPY_AND_ASSIGN(CheckStackOverflowInstr);
 };
 
 
+// TODO(vegorov): remove this instruction in favor of Int32ToDouble.
 class SmiToDoubleInstr : public TemplateDefinition<1> {
  public:
   SmiToDoubleInstr(Value* value, intptr_t token_pos)
       : token_pos_(token_pos) {
     SetInputAt(0, value);
   }
 
   Value* value() const { return inputs_[0]; }
   virtual intptr_t token_pos() const { return token_pos_; }
 
@@ skipping 15 matching lines @@
 
   virtual bool MayThrow() const { return false; }
 
  private:
   const intptr_t token_pos_;
 
   DISALLOW_COPY_AND_ASSIGN(SmiToDoubleInstr);
 };
 
 
+class Int32ToDoubleInstr : public TemplateDefinition<1> {
+ public:
+  explicit Int32ToDoubleInstr(Value* value) {
+    SetInputAt(0, value);
+  }
+
+  Value* value() const { return inputs_[0]; }
+
+  DECLARE_INSTRUCTION(Int32ToDouble)
+  virtual CompileType ComputeType() const;
+
+  virtual Representation RequiredInputRepresentation(intptr_t index) const {
+    ASSERT(index == 0);
+    return kUnboxedInt32;
+  }
+
+  virtual Representation representation() const {
+    return kUnboxedDouble;
+  }
+
+  virtual bool CanDeoptimize() const { return false; }
+
+  virtual bool AllowsCSE() const { return true; }
+  virtual EffectSet Effects() const { return EffectSet::None(); }
+  virtual EffectSet Dependencies() const { return EffectSet::None(); }
+  virtual bool AttributesEqual(Instruction* other) const { return true; }
+
+  virtual bool MayThrow() const { return false; }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(Int32ToDoubleInstr);
+};
+
+
 class DoubleToIntegerInstr : public TemplateDefinition<1> {
  public:
   DoubleToIntegerInstr(Value* value, InstanceCallInstr* instance_call)
       : instance_call_(instance_call) {
     SetInputAt(0, value);
     deopt_id_ = instance_call->deopt_id();
   }
 
   Value* value() const { return inputs_[0]; }
   InstanceCallInstr* instance_call() const { return instance_call_; }
@@ skipping 739 matching lines @@
 
   virtual bool MayThrow() const { return false; }
 
  private:
   const Token::Kind op_kind_;
 
   DISALLOW_COPY_AND_ASSIGN(UnaryUint32OpInstr);
 };
 
 
-class BoxUint32Instr : public TemplateDefinition<1> {
+class BoxIntNInstr : public TemplateDefinition<1> {
  public:
-  explicit BoxUint32Instr(Value* value) {
+  BoxIntNInstr(Representation representation, Value* value)
+      : representation_(representation) {
     SetInputAt(0, value);
   }
 
   Value* value() const { return inputs_[0]; }
+  virtual bool ValueFitsSmi() const;
+
+  virtual CompileType ComputeType() const;
+  virtual bool RecomputeType();
 
   virtual bool CanDeoptimize() const { return false; }
 
   virtual intptr_t DeoptimizationTarget() const {
     return Isolate::kNoDeoptId;
   }
 
   virtual Representation RequiredInputRepresentation(intptr_t idx) const {
     ASSERT(idx == 0);
-    return kUnboxedUint32;
+    return representation_;
   }
 
-  DECLARE_INSTRUCTION(BoxUint32)
-  virtual CompileType ComputeType() const;
-
   virtual bool AllowsCSE() const { return true; }
   virtual EffectSet Effects() const { return EffectSet::None(); }
   virtual EffectSet Dependencies() const { return EffectSet::None(); }
-  virtual bool AttributesEqual(Instruction* other) const { return true; }
+  virtual bool AttributesEqual(Instruction* other) const {
+    return other->AsBoxIntN()->representation_ == representation_;
+  }
 
   virtual bool MayThrow() const { return false; }
 
+  virtual Definition* Canonicalize(FlowGraph* flow_graph);
+
+  virtual BoxIntNInstr* AsBoxIntN() { return this; }
+
+ private:
+  const Representation representation_;
+
+  DISALLOW_COPY_AND_ASSIGN(BoxIntNInstr);
+};
+
+
+class BoxUint32Instr : public BoxIntNInstr {
+ public:
+  explicit BoxUint32Instr(Value* value)
+      : BoxIntNInstr(kUnboxedUint32, value) { }
+
+  DECLARE_INSTRUCTION(BoxUint32)
+
  private:
   DISALLOW_COPY_AND_ASSIGN(BoxUint32Instr);
 };
 
 
-class UnboxUint32Instr : public TemplateDefinition<1> {
+class BoxInt32Instr : public BoxIntNInstr {
  public:
-  UnboxUint32Instr(Value* value, intptr_t deopt_id) {
+  explicit BoxInt32Instr(Value* value)
+      : BoxIntNInstr(kUnboxedInt32, value) { }
+
+  virtual void InferRange(RangeAnalysis* analysis, Range* range);
+
+  DECLARE_INSTRUCTION(BoxInt32)
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(BoxInt32Instr);
+};
+
+
+class UnboxIntNInstr : public TemplateDefinition<1> {
+ public:
+  UnboxIntNInstr(Representation representation,
+                 Value* value,
+                 intptr_t deopt_id)
+      : representation_(representation) {
     SetInputAt(0, value);
     deopt_id_ = deopt_id;
   }
 
   Value* value() const { return inputs_[0]; }
 
+  virtual Representation representation() const {
+    return representation_;
+  }
+
+  virtual CompileType ComputeType() const;
+
+  virtual bool AllowsCSE() const { return true; }
+  virtual EffectSet Effects() const { return EffectSet::None(); }
+  virtual EffectSet Dependencies() const { return EffectSet::None(); }
+  virtual bool AttributesEqual(Instruction* other) const {
+    return other->AsUnboxIntN()->representation_ == representation_;
+  }
+
+  virtual bool MayThrow() const { return false; }
+
+  virtual Definition* Canonicalize(FlowGraph* flow_graph);
+
+  virtual UnboxIntNInstr* AsUnboxIntN() { return this; }
+
+ private:
+  const Representation representation_;
+
+  DISALLOW_COPY_AND_ASSIGN(UnboxIntNInstr);
+};
+
+
+class UnboxUint32Instr : public UnboxIntNInstr {
+ public:
+  UnboxUint32Instr(Value* value, intptr_t deopt_id)
+      : UnboxIntNInstr(kUnboxedUint32, value, deopt_id) {
+  }
+
   virtual bool CanDeoptimize() const {
     return (value()->Type()->ToCid() != kSmiCid)
         && (value()->Type()->ToCid() != kMintCid);
   }
 
-  virtual Representation representation() const {
-    return kUnboxedUint32;
-  }
-
-
   DECLARE_INSTRUCTION(UnboxUint32)
-  virtual CompileType ComputeType() const;
-
-  virtual bool AllowsCSE() const { return true; }
-  virtual EffectSet Effects() const { return EffectSet::None(); }
-  virtual EffectSet Dependencies() const { return EffectSet::None(); }
-  virtual bool AttributesEqual(Instruction* other) const { return true; }
-
-  virtual bool MayThrow() const { return false; }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(UnboxUint32Instr);
 };
 
 
+class UnboxInt32Instr : public UnboxIntNInstr {
+ public:
+  UnboxInt32Instr(Value* value, intptr_t deopt_id)
+      : UnboxIntNInstr(kUnboxedInt32, value, deopt_id) {
+  }
+
+  virtual bool CanDeoptimize() const;
+
+  virtual void InferRange(RangeAnalysis* analysis, Range* range);
+
+  virtual Definition* Canonicalize(FlowGraph* flow_graph);
+
+  DECLARE_INSTRUCTION(UnboxInt32)
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(UnboxInt32Instr);
+};
+
+
 class UnboxedIntConverterInstr : public TemplateDefinition<1> {
  public:
   UnboxedIntConverterInstr(Representation from,
                            Representation to,
-                           Value* value)
+                           Value* value,
+                           intptr_t deopt_id)
       : from_representation_(from),
         to_representation_(to) {
     ASSERT(from != to);
-    ASSERT((from == kUnboxedMint) || (from == kUnboxedUint32));
-    ASSERT((to == kUnboxedMint) || (to == kUnboxedUint32));
+    ASSERT((from == kUnboxedMint) ||
+           (from == kUnboxedUint32) ||
+           (from == kUnboxedInt32));
+    ASSERT((to == kUnboxedMint) ||
+           (to == kUnboxedUint32) ||
+           (to == kUnboxedInt32));
+    ASSERT((to != kUnboxedInt32) || (deopt_id != Isolate::kNoDeoptId));
     SetInputAt(0, value);
+    deopt_id_ = deopt_id;
   }
 
   Value* value() const { return inputs_[0]; }
 
   Representation from() const { return from_representation_; }
   Representation to() const { return to_representation_; }
 
-  virtual bool CanDeoptimize() const { return false; }
+  Definition* Canonicalize(FlowGraph* flow_graph);
+
+  virtual bool CanDeoptimize() const;
 
   virtual Representation representation() const {
     return to();
   }
 
   virtual Representation RequiredInputRepresentation(intptr_t idx) const {
     ASSERT(idx == 0);
     return from();
   }
 
   virtual EffectSet Effects() const { return EffectSet::None(); }
   virtual EffectSet Dependencies() const { return EffectSet::None(); }
   virtual bool AttributesEqual(Instruction* other) const {
     ASSERT(other->IsUnboxedIntConverter());
     UnboxedIntConverterInstr* converter = other->AsUnboxedIntConverter();
     return (converter->from() == from()) && (converter->to() == to());
   }
 
   virtual bool MayThrow() const { return false; }
 
+  virtual void InferRange(RangeAnalysis* analysis, Range* range);
+
+  virtual void PrintOperandsTo(BufferFormatter* f) const;
+
   DECLARE_INSTRUCTION(UnboxedIntConverter);
 
  private:
   const Representation from_representation_;
   const Representation to_representation_;
   DISALLOW_COPY_AND_ASSIGN(UnboxedIntConverterInstr);
 };
 
 
 #undef DECLARE_INSTRUCTION
@@ skipping 216 matching lines @@
 
  protected:
   const GrowableArray<BlockEntryInstr*>& block_order_;
   ForwardInstructionIterator* current_iterator_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
 };
 
 
+// Helper macros for platform ports.
+#define DEFINE_UNIMPLEMENTED_INSTRUCTION(Name)                                \
+  LocationSummary* Name::MakeLocationSummary(                                 \
+      Isolate* isolate, bool opt) const {                                     \
+    UNIMPLEMENTED();                                                          \
+    return NULL;                                                              \
+  }                                                                           \
+  void Name::EmitNativeCode(FlowGraphCompiler* compiler) { UNIMPLEMENTED(); }
+
+
 }  // namespace dart
 
 #endif  // VM_INTERMEDIATE_LANGUAGE_H_