Support Int32 representation for selected binary operations.

runtime/vm/flow_graph_allocator.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_allocator.h"
 
 #include "vm/bit_vector.h"
 #include "vm/intermediate_language.h"
 #include "vm/il_printer.h"
 #include "vm/flow_graph.h"
@@ skipping 605 matching lines @@
     // Slot index for the leftmost copied parameter is 0.
     intptr_t slot_index = param->index();
     // Slot index for the rightmost fixed parameter is -1.
     slot_index -= flow_graph_.num_non_copied_params();
 
     range->set_assigned_location(Location::StackSlot(slot_index));
     range->set_spill_slot(Location::StackSlot(slot_index));
   } else {
     ConstantInstr* constant = defn->AsConstant();
     ASSERT(constant != NULL);
-    range->set_assigned_location(Location::Constant(constant->value()));
-    range->set_spill_slot(Location::Constant(constant->value()));
+    range->set_assigned_location(Location::Constant(constant));
+    range->set_spill_slot(Location::Constant(constant));
   }
   AssignSafepoints(defn, range);
   range->finger()->Initialize(range);
   UsePosition* use =
       range->finger()->FirstRegisterBeneficialUse(block->start_pos());
   if (use != NULL) {
     LiveRange* tail =
         SplitBetween(range, block->start_pos(), use->pos());
     // Parameters and constants are tagged, so allocated to CPU registers.
     CompleteRange(tail, Location::kRegister);
@@ skipping 89 matching lines @@
   // Record the corresponding phi input use for each phi.
   intptr_t move_idx = 0;
   for (PhiIterator it(join); !it.Done(); it.Advance()) {
     // TODO(johnmccutchan): Fix handling of PhiInstr with PairLocation.
     PhiInstr* phi = it.Current();
     Value* val = phi->InputAt(pred_idx);
     MoveOperands* move = parallel_move->MoveOperandsAt(move_idx);
 
     ConstantInstr* constant = val->definition()->AsConstant();
     if (constant != NULL) {
-      move->set_src(Location::Constant(constant->value()));
+      move->set_src(Location::Constant(constant));
       move_idx++;
       continue;
     }
 
     // Expected shape of live ranges:
     //
     //                 g  g'
     //      value    --*
     //
 
@@ skipping 94 matching lines @@
       }
 
       if (def->IsPushArgument()) {
         // Frame size is unknown until after allocation.
         locations[i] = Location::NoLocation();
         continue;
       }
 
       ConstantInstr* constant = def->AsConstant();
       if (constant != NULL) {
-        locations[i] = Location::Constant(constant->value());
+        locations[i] = Location::Constant(constant);
         continue;
       }
 
       MaterializeObjectInstr* mat = def->AsMaterializeObject();
       if (mat != NULL) {
         // MaterializeObject itself produces no value. But its uses
         // are treated as part of the environment: allocated locations
         // will be used when building deoptimization data.
         locations[i] = Location::NoLocation();
         ProcessMaterializationUses(block, block_start_pos, use_pos, mat);
@@ skipping 42 matching lines @@
   // Initialize location for every input of the MaterializeObject instruction.
   Location* locations =
       Isolate::Current()->current_zone()->Alloc<Location>(mat->InputCount());
   mat->set_locations(locations);
 
   for (intptr_t i = 0; i < mat->InputCount(); ++i) {
     Definition* def = mat->InputAt(i)->definition();
 
     ConstantInstr* constant = def->AsConstant();
     if (constant != NULL) {
-      locations[i] = Location::Constant(constant->value());
+      locations[i] = Location::Constant(constant);
       continue;
     }
 
     if (def->HasPairRepresentation()) {
       locations[i] = Location::Pair(Location::Any(), Location::Any());
       PairLocation* location_pair = locations[i].AsPairLocation();
       {
         // First live range.
         LiveRange* range = GetLiveRange(def->ssa_temp_index());
         range->AddUseInterval(block_start_pos, use_pos);
@@ skipping 217 matching lines @@
     if ((range == NULL) || (range->first_use() == NULL)) {
       locs->set_out(0, Location::NoLocation());
       return;
     }
 
     // If this constant has only unconstrained uses convert them all
     // to use the constant directly and drop this definition.
     // TODO(vegorov): improve allocation when we have enough registers to keep
     // constants used in the loop in them.
     if (HasOnlyUnconstrainedUses(range)) {
-      const Object& value = def->AsConstant()->value();
-      range->set_assigned_location(Location::Constant(value));
-      range->set_spill_slot(Location::Constant(value));
+      ConstantInstr* constant_instr = def->AsConstant();
+      range->set_assigned_location(Location::Constant(constant_instr));
+      range->set_spill_slot(Location::Constant(constant_instr));
       range->finger()->Initialize(range);
       ConvertAllUses(range);
 
       locs->set_out(0, Location::NoLocation());
       return;
     }
   }
 
   const intptr_t pos = current->lifetime_position();
   ASSERT(IsInstructionStartPosition(pos));
@@ skipping 1751 matching lines @@
     OS::Print("-- [after ssa allocator] ir [%s] -------------\n",
               function.ToFullyQualifiedCString());
     FlowGraphPrinter printer(flow_graph_, true);
     printer.PrintBlocks();
     OS::Print("----------------------------------------------\n");
   }
 }
 
 
 }  // namespace dart