Rendering text-justify:none

Rendering text-justify:none

When the value of text-justify is 'none',
we don't need to touch anything related to the expansion opportunity.
We just need to leave the expansion opportunity as 0,
so that justification doesn't work for this case.

BUG=248894
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161006

[dw.im, 2013-10-30 03:33:26]

First step to implement the rendering part of the text-justify property.

[dw.im, 2013-10-30 03:36:08]

I believe we don't need to do anything to take care of the two values of the
property - auto, and inter-word.

The existed algorithm for text-align:justify works for the value, very nicely.

[Julien - ping for review, 2013-10-30 23:41:40]

Levi or Eric are better reviewers for line layout code.

[leviw_travelin_and_unemployed, 2013-10-31 00:01:11]

https://codereview.chromium.org/50413008/diff/40002/Source/core/rendering/Ren...
File Source/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/50413008/diff/40002/Source/core/rendering/Ren...
Source/core/rendering/RenderBlockLineLayout.cpp:1016: TextJustify textJustify =
style()->textJustify();
I'd rather see this as a boolean. isTextJustifyNone, or
needsExpansionCalculation, etc.

https://codereview.chromium.org/50413008/diff/40002/Source/core/rendering/Ren...
Source/core/rendering/RenderBlockLineLayout.cpp:1064: if (textJustify !=
TextJustifyNone && isAfterExpansion && !expansionOpportunities.isEmpty()) {
Is this necessary? Won't it be covered by the existing
!expansionOpportunities.isEmpty() check?

[dw.im, 2013-10-31 00:16:32]

https://codereview.chromium.org/50413008/diff/40002/Source/core/rendering/Ren...
File Source/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/50413008/diff/40002/Source/core/rendering/Ren...
Source/core/rendering/RenderBlockLineLayout.cpp:1016: TextJustify textJustify =
style()->textJustify();
On 2013/10/31 00:01:11, Levi wrote:
> I'd rather see this as a boolean. isTextJustifyNone, or
> needsExpansionCalculation, etc.

After sometime, we need to check text-justify:distribute which is
inter-character justification.
I think we can keep this variable as TextJustify type so that we can use it to
check style()->textJuatify() is none, distribute, or others.

https://codereview.chromium.org/50413008/diff/40002/Source/core/rendering/Ren...
Source/core/rendering/RenderBlockLineLayout.cpp:1064: if (textJustify !=
TextJustifyNone && isAfterExpansion && !expansionOpportunities.isEmpty()) {
On 2013/10/31 00:01:11, Levi wrote:
> Is this necessary? Won't it be covered by the existing
> !expansionOpportunities.isEmpty() check?

Hmm. yes. It seems expansionOpportunities would be empty at this point.
I can remove this condition, then.

[leviw_travelin_and_unemployed, 2013-10-31 00:23:59]

Okay. LGTM.

[commit-bot: I haz the power, 2013-10-31 00:29:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dw.im@samsung.com/50413008/110001

[commit-bot: I haz the power, 2013-10-31 00:36:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dw.im@samsung.com/50413008/250001

[commit-bot: I haz the power, 2013-10-31 02:18:30]

Change committed as 161006