Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects.cc

Issue 50413004: Removed RelocInfo::target_object_address() and reconstructed_obj_ptr_. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/assembler-mips-inl.h ('k') | src/serialize.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 10299 matching lines...) Expand 10 before | Expand all | Expand 10 after
10310 rinfo->IsPatchedDebugBreakSlotSequence())); 10310 rinfo->IsPatchedDebugBreakSlotSequence()));
10311 Object* target = Code::GetCodeFromTargetAddress(rinfo->call_address()); 10311 Object* target = Code::GetCodeFromTargetAddress(rinfo->call_address());
10312 Object* old_target = target; 10312 Object* old_target = target;
10313 VisitPointer(&target); 10313 VisitPointer(&target);
10314 CHECK_EQ(target, old_target); // VisitPointer doesn't change Code* *target. 10314 CHECK_EQ(target, old_target); // VisitPointer doesn't change Code* *target.
10315 } 10315 }
10316 10316
10317 10317
10318 void ObjectVisitor::VisitEmbeddedPointer(RelocInfo* rinfo) { 10318 void ObjectVisitor::VisitEmbeddedPointer(RelocInfo* rinfo) {
10319 ASSERT(rinfo->rmode() == RelocInfo::EMBEDDED_OBJECT); 10319 ASSERT(rinfo->rmode() == RelocInfo::EMBEDDED_OBJECT);
10320 VisitPointer(rinfo->target_object_address()); 10320 Object* p = rinfo->target_object();
10321 VisitPointer(&p);
10321 } 10322 }
10322 10323
10323 10324
10324 void ObjectVisitor::VisitExternalReference(RelocInfo* rinfo) { 10325 void ObjectVisitor::VisitExternalReference(RelocInfo* rinfo) {
10325 Address p = rinfo->target_reference(); 10326 Address p = rinfo->target_reference();
10326 VisitExternalReference(&p); 10327 VisitExternalReference(&p);
10327 } 10328 }
10328 10329
10329 10330
10330 void Code::InvalidateRelocation() { 10331 void Code::InvalidateRelocation() {
(...skipping 6065 matching lines...) Expand 10 before | Expand all | Expand 10 after
16396 #define ERROR_MESSAGES_TEXTS(C, T) T, 16397 #define ERROR_MESSAGES_TEXTS(C, T) T,
16397 static const char* error_messages_[] = { 16398 static const char* error_messages_[] = {
16398 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 16399 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
16399 }; 16400 };
16400 #undef ERROR_MESSAGES_TEXTS 16401 #undef ERROR_MESSAGES_TEXTS
16401 return error_messages_[reason]; 16402 return error_messages_[reason];
16402 } 16403 }
16403 16404
16404 16405
16405 } } // namespace v8::internal 16406 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/assembler-mips-inl.h ('k') | src/serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698