Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 504093002: Fix and re-enable test-api/InitializeAndDispose. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix and re-enable test-api/InitializeAndDispose. R=svenpanne@chromium.org TEST=cctest/test-api/InitializeAndDispose Committed: https://code.google.com/p/v8/source/detail?r=23401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/elements.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/lithium.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/sampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-08-26 12:39:24 UTC) #1
Sven Panne
lgtm
6 years, 3 months ago (2014-08-26 12:50:15 UTC) #2
Michael Starzinger
6 years, 3 months ago (2014-08-26 13:07:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23401 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698