Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: chrome/browser/cocoa/about_window_controller.mm

Issue 504065: Remove svn revision from branded builds. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/about_chrome_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/about_window_controller.mm
===================================================================
--- chrome/browser/cocoa/about_window_controller.mm (revision 34980)
+++ chrome/browser/cocoa/about_window_controller.mm (working copy)
@@ -129,16 +129,20 @@
[bundle objectForInfoDictionaryKey:@"CFBundleShortVersionString"];
NSString* versionModifier = @"";
+ NSString* svnRevision = @"";
string16 modifier = platform_util::GetVersionStringModifier();
if (modifier.length())
versionModifier = [NSString stringWithFormat:@" %@",
base::SysUTF16ToNSString(modifier)];
+#if !defined(GOOGLE_CHROME_BUILD)
+ svnRevision = [NSString stringWithFormat:@" (%@)",
+ [bundle objectForInfoDictionaryKey:@"SVNRevision"]];
+#endif
// The format string is not localized, but this is how the displayed version
// is built on Windows too.
- NSString* svnRevision = [bundle objectForInfoDictionaryKey:@"SVNRevision"];
NSString* version =
- [NSString stringWithFormat:@"%@ (%@)%@",
+ [NSString stringWithFormat:@"%@%@%@",
chromeVersion, svnRevision, versionModifier];
[version_ setStringValue:version];
« no previous file with comments | « no previous file | chrome/browser/gtk/about_chrome_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698