Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 504033002: Make app list ContentsView scroll vertically in experimental app list. (Closed)

Created:
6 years, 3 months ago by calamity
Modified:
6 years, 3 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Make app list ContentsView scroll vertically in experimental app list. This CL makes the app list contents view scroll vertically for the experimental app list rather than horiztonally. BUG=406222 Committed: https://crrev.com/f66329ebdc0b11940a1d016257ef92fad572fcd8 Cr-Commit-Position: refs/heads/master@{#291854}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M ui/app_list/views/contents_view.cc View 1 1 chunk +6 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
calamity
calamity@chromium.org changed reviewers: + mgiuca@chromium.org
6 years, 3 months ago (2014-08-26 03:16:26 UTC) #1
calamity
6 years, 3 months ago (2014-08-26 03:16:26 UTC) #2
Matt Giuca
lgtm https://codereview.chromium.org/504033002/diff/1/ui/app_list/views/contents_view.cc File ui/app_list/views/contents_view.cc (right): https://codereview.chromium.org/504033002/diff/1/ui/app_list/views/contents_view.cc#newcode218 ui/app_list/views/contents_view.cc:218: // The normal app list transitions vertically. Replace ...
6 years, 3 months ago (2014-08-26 03:21:53 UTC) #3
calamity
https://codereview.chromium.org/504033002/diff/1/ui/app_list/views/contents_view.cc File ui/app_list/views/contents_view.cc (right): https://codereview.chromium.org/504033002/diff/1/ui/app_list/views/contents_view.cc#newcode218 ui/app_list/views/contents_view.cc:218: // The normal app list transitions vertically. On 2014/08/26 ...
6 years, 3 months ago (2014-08-26 03:23:50 UTC) #4
calamity
Patchset #2 (id:20001) has been deleted
6 years, 3 months ago (2014-08-26 03:24:40 UTC) #5
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 3 months ago (2014-08-26 03:24:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/504033002/40001
6 years, 3 months ago (2014-08-26 03:26:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (40001) as 2b6f07753f7ccf719cc13e6d95ac199a1b9a3de4
6 years, 3 months ago (2014-08-26 06:27:16 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:40:59 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f66329ebdc0b11940a1d016257ef92fad572fcd8
Cr-Commit-Position: refs/heads/master@{#291854}

Powered by Google App Engine
This is Rietveld 408576698