Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: ui/gfx/geometry/rect_f.h

Issue 503953002: Do not use extern template declarations for RectBase etc for NaCl builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/gfx/geometry/rect.h ('k') | ui/gfx/geometry/size.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_GFX_GEOMETRY_RECT_F_H_ 5 #ifndef UI_GFX_GEOMETRY_RECT_F_H_
6 #define UI_GFX_GEOMETRY_RECT_F_H_ 6 #define UI_GFX_GEOMETRY_RECT_F_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 #include <string> 9 #include <string>
10 10
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 } 98 }
99 99
100 // Constructs a rectangle with |p1| and |p2| as opposite corners. 100 // Constructs a rectangle with |p1| and |p2| as opposite corners.
101 // 101 //
102 // This could also be thought of as "the smallest rect that contains both 102 // This could also be thought of as "the smallest rect that contains both
103 // points", except that we consider points on the right/bottom edges of the 103 // points", except that we consider points on the right/bottom edges of the
104 // rect to be outside the rect. So technically one or both points will not be 104 // rect to be outside the rect. So technically one or both points will not be
105 // contained within the rect, because they will appear on one of these edges. 105 // contained within the rect, because they will appear on one of these edges.
106 GFX_EXPORT RectF BoundingRect(const PointF& p1, const PointF& p2); 106 GFX_EXPORT RectF BoundingRect(const PointF& p1, const PointF& p2);
107 107
108 #if !defined(COMPILER_MSVC) 108 #if !defined(COMPILER_MSVC) && !defined(__native_client__)
109 extern template class RectBase<RectF, PointF, SizeF, InsetsF, Vector2dF, float>; 109 extern template class RectBase<RectF, PointF, SizeF, InsetsF, Vector2dF, float>;
110 #endif 110 #endif
111 111
112 // This is declared here for use in gtest-based unit tests but is defined in 112 // This is declared here for use in gtest-based unit tests but is defined in
113 // the gfx_test_support target. Depend on that to use this in your unit test. 113 // the gfx_test_support target. Depend on that to use this in your unit test.
114 // This should not be used in production code - call ToString() instead. 114 // This should not be used in production code - call ToString() instead.
115 void PrintTo(const RectF& rect, ::std::ostream* os); 115 void PrintTo(const RectF& rect, ::std::ostream* os);
116 116
117 } // namespace gfx 117 } // namespace gfx
118 118
119 #endif // UI_GFX_GEOMETRY_RECT_F_H_ 119 #endif // UI_GFX_GEOMETRY_RECT_F_H_
OLDNEW
« no previous file with comments | « ui/gfx/geometry/rect.h ('k') | ui/gfx/geometry/size.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698