Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 503933002: Remove implicit conversions from scoped_refptr to T* in content/browser/frame_host (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
nasko
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in content/browser/frame_host This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/0a51daeb1a5014e95b64b5e01fe52a386afd3c5b Cr-Commit-Position: refs/heads/master@{#291922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M content/browser/frame_host/frame_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + nasko@chromium.org
6 years, 4 months ago (2014-08-25 21:47:50 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 4 months ago (2014-08-25 21:47:50 UTC) #2
nasko
LGTM
6 years, 3 months ago (2014-08-26 16:08:00 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 16:08:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/503933002/1
6 years, 3 months ago (2014-08-26 16:08:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 17:03:07 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-26 17:03:08 UTC) #7
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 17:03:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/503933002/1
6 years, 3 months ago (2014-08-26 17:04:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (1) as 90fcf3075de0ce16c71ca2f039ba9162baad0dd4
6 years, 3 months ago (2014-08-26 17:06:20 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:43:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a51daeb1a5014e95b64b5e01fe52a386afd3c5b
Cr-Commit-Position: refs/heads/master@{#291922}

Powered by Google App Engine
This is Rietveld 408576698