Issue 503913002: IndexedDB: Decode correct int type for database name->id map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 503913002: IndexedDB: Decode correct int type for database name->id map (Closed)

Created:
6 years, 4 months ago by jsbell

Modified:
6 years, 3 months ago

Reviewers:
cmumford

CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

IndexedDB: Decode correct int type for database name->id map Database enumeration was decoding id as VarInt, but it's a plain Int. R=cmumford@chromium.org BUG=407015 Committed: https://crrev.com/3f53c98b9f006356647858f34074bb9bb42537e3 Cr-Commit-Position: refs/heads/master@{#291792}

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	content/browser/indexed_db/indexed_db_backing_store.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/browser/indexed_db/indexed_db_leveldb_coding.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

jsbell

Speculative fix for https://code.google.com/p/chromium/issues/detail?id=407015 - the code is definitely wrong, but I can't repro the ...

6 years, 4 months ago (2014-08-25 21:43:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/503913002/1

6 years, 4 months ago (2014-08-25 21:59:09 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (1) as 7a520a996e2a75004c3d57c188b7a9e461af4c7c

6 years, 4 months ago (2014-08-25 23:48:30 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:38:43 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3f53c98b9f006356647858f34074bb9bb42537e3
Cr-Commit-Position: refs/heads/master@{#291792}