sync/internal_api/attachments/attachment_uploader_impl.cc - Issue 503903002: Remove implicit conversions from scoped_refptr to T* in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/attachment_uploader_impl.cc

Issue 503903002: Remove implicit conversions from scoped_refptr to T* in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/attachments/attachment_uploader_impl.cc

diff --git a/sync/internal_api/attachments/attachment_uploader_impl.cc b/sync/internal_api/attachments/attachment_uploader_impl.cc

index a6614ef1044bdd50b3e5828a5df9397971d123c7..4d197eb6da7edb9d4114c7111c77b0eafe15aca3 100644

--- a/sync/internal_api/attachments/attachment_uploader_impl.cc

+++ b/sync/internal_api/attachments/attachment_uploader_impl.cc

@@ -108,7 +108,7 @@ AttachmentUploaderImpl::UploadState::UploadState(

token_service_provider_(token_service_provider),

owner_(owner) {

DCHECK(upload_url_.is_valid());

- DCHECK(url_request_context_getter_);

+ DCHECK(url_request_context_getter_.get());

DCHECK(!account_id_.empty());

DCHECK(!scopes_.empty());

DCHECK(token_service_provider_);

@@ -222,7 +222,7 @@ AttachmentUploaderImpl::AttachmentUploaderImpl(

DCHECK(CalledOnValidThread());

DCHECK(!account_id.empty());

DCHECK(!scopes.empty());

- DCHECK(token_service_provider_);

+ DCHECK(token_service_provider_.get());

}

AttachmentUploaderImpl::~AttachmentUploaderImpl() {

« no previous file with comments | « sync/internal_api/attachments/attachment_service_proxy_for_test.cc ('k') | sync/internal_api/http_bridge.cc » ('j') | no next file with comments »