Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: sync/internal_api/attachments/attachment_service_proxy.cc

Issue 503903002: Remove implicit conversions from scoped_refptr to T* in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/attachments/attachment_service_proxy.cc
diff --git a/sync/internal_api/attachments/attachment_service_proxy.cc b/sync/internal_api/attachments/attachment_service_proxy.cc
index 9f408b237f6ae39d7eeedf7bfe4900d6a93117ff..1d418788e11ffdf71c1115484a2f0d7e8b1ae24f 100644
--- a/sync/internal_api/attachments/attachment_service_proxy.cc
+++ b/sync/internal_api/attachments/attachment_service_proxy.cc
@@ -53,15 +53,15 @@ AttachmentServiceProxy::AttachmentServiceProxy(
const scoped_refptr<base::SequencedTaskRunner>& wrapped_task_runner,
const base::WeakPtr<syncer::AttachmentService>& wrapped)
: wrapped_task_runner_(wrapped_task_runner), core_(new Core(wrapped)) {
- DCHECK(wrapped_task_runner_);
+ DCHECK(wrapped_task_runner_.get());
}
AttachmentServiceProxy::AttachmentServiceProxy(
const scoped_refptr<base::SequencedTaskRunner>& wrapped_task_runner,
const scoped_refptr<Core>& core)
: wrapped_task_runner_(wrapped_task_runner), core_(core) {
- DCHECK(wrapped_task_runner_);
- DCHECK(core_);
+ DCHECK(wrapped_task_runner_.get());
+ DCHECK(core_.get());
}
AttachmentServiceProxy::~AttachmentServiceProxy() {
@@ -70,7 +70,7 @@ AttachmentServiceProxy::~AttachmentServiceProxy() {
void AttachmentServiceProxy::GetOrDownloadAttachments(
const AttachmentIdList& attachment_ids,
const GetOrDownloadCallback& callback) {
- DCHECK(wrapped_task_runner_);
+ DCHECK(wrapped_task_runner_.get());
GetOrDownloadCallback proxy_callback =
base::Bind(&ProxyGetOrDownloadCallback,
base::ThreadTaskRunnerHandle::Get(),
@@ -86,7 +86,7 @@ void AttachmentServiceProxy::GetOrDownloadAttachments(
void AttachmentServiceProxy::DropAttachments(
const AttachmentIdList& attachment_ids,
const DropCallback& callback) {
- DCHECK(wrapped_task_runner_);
+ DCHECK(wrapped_task_runner_.get());
DropCallback proxy_callback = base::Bind(
&ProxyDropCallback, base::ThreadTaskRunnerHandle::Get(), callback);
wrapped_task_runner_->PostTask(FROM_HERE,
@@ -98,7 +98,7 @@ void AttachmentServiceProxy::DropAttachments(
void AttachmentServiceProxy::StoreAttachments(const AttachmentList& attachments,
const StoreCallback& callback) {
- DCHECK(wrapped_task_runner_);
+ DCHECK(wrapped_task_runner_.get());
StoreCallback proxy_callback = base::Bind(
&ProxyStoreCallback, base::ThreadTaskRunnerHandle::Get(), callback);
wrapped_task_runner_->PostTask(

Powered by Google App Engine
This is Rietveld 408576698