sync/api/attachments/attachment.cc - Issue 503903002: Remove implicit conversions from scoped_refptr to T* in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/attachments/attachment.cc

Issue 503903002: Remove implicit conversions from scoped_refptr to T* in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/api/attachments/attachment.cc

diff --git a/sync/api/attachments/attachment.cc b/sync/api/attachments/attachment.cc

index b5cfe5d621416da43d439a9ae5ba898f8c3f7039..3a4dfc3ed7b6f9806dfd34275bcb33acc5392294 100644

--- a/sync/api/attachments/attachment.cc

+++ b/sync/api/attachments/attachment.cc

@@ -32,7 +32,7 @@ const scoped_refptr<base::RefCountedMemory>& Attachment::GetData() const {

Attachment::Attachment(const AttachmentId& id,

const scoped_refptr<base::RefCountedMemory>& data)

: id_(id), data_(data) {

- DCHECK(data);

+ DCHECK(data.get());

}

} // namespace syncer

« no previous file with comments | « no previous file | sync/engine/syncer_unittest.cc » ('j') | no next file with comments »