Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 503883005: Remove implicit conversions from scoped_refptr to T* in components/autofill/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
benquan, browser-components-watch_chromium.org, chromium-reviews, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, jam, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in components/autofill/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/35b4b0bd068055afa9a243bf899f3ead4f8f95b7 Cr-Commit-Position: refs/heads/master@{#291956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M components/autofill/content/browser/wallet/wallet_client_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_download_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + isherman@chromium.org
6 years, 3 months ago (2014-08-26 16:19:53 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 3 months ago (2014-08-26 16:19:53 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years, 3 months ago (2014-08-26 17:23:42 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 17:29:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/503883005/1
6 years, 3 months ago (2014-08-26 17:31:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 42cc99903e203f553beb6508aa0325a797f56a4f
6 years, 3 months ago (2014-08-26 19:12:02 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:44:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35b4b0bd068055afa9a243bf899f3ead4f8f95b7
Cr-Commit-Position: refs/heads/master@{#291956}

Powered by Google App Engine
This is Rietveld 408576698