Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: ui/events/gestures/gesture_recognizer_impl.cc

Issue 503883004: Don't pass touches to gesture recognizer for async acks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address sadrul's comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/gestures/gesture_recognizer_impl.cc
diff --git a/ui/events/gestures/gesture_recognizer_impl.cc b/ui/events/gestures/gesture_recognizer_impl.cc
index 7250bf220580e260c7ed74d4cd89377f578d7028..774350353309cf1ddb1d63a94ce3c6dee94433f3 100644
--- a/ui/events/gestures/gesture_recognizer_impl.cc
+++ b/ui/events/gestures/gesture_recognizer_impl.cc
@@ -251,9 +251,11 @@ bool GestureRecognizerImpl::ProcessTouchEventPreDispatch(
return gesture_provider->OnTouchEvent(event);
}
+// TODO(tdresser): we should take a unique_event_id here, and validate
+// that the correct event is being acked. See crbug.com/457669 for
+// details.
GestureRecognizer::Gestures*
GestureRecognizerImpl::AckAsyncTouchEvent(
- const TouchEvent& event,
ui::EventResult result,
GestureConsumer* consumer) {
GestureProviderAura* gesture_provider =

Powered by Google App Engine
This is Rietveld 408576698