ui/events/gesture_detection/touch_disposition_gesture_filter.cc - Issue 503883004: Don't pass touches to gesture recognizer for async acks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_detection/touch_disposition_gesture_filter.cc

Issue 503883004: Don't pass touches to gesture recognizer for async acks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address sadrul's comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/gesture_detection/touch_disposition_gesture_filter.cc

diff --git a/ui/events/gesture_detection/touch_disposition_gesture_filter.cc b/ui/events/gesture_detection/touch_disposition_gesture_filter.cc

index 0fa42bd2dc7771b62f58c8ecf01f12592bcdb724..b4c25cadc23631b96d349b4c15abb81088e7e266 100644

--- a/ui/events/gesture_detection/touch_disposition_gesture_filter.cc

+++ b/ui/events/gesture_detection/touch_disposition_gesture_filter.cc

@@ -172,7 +172,7 @@ TouchDispositionGestureFilter::OnGesturePacket(

void TouchDispositionGestureFilter::OnTouchEventAckForQueueFront(

bool event_consumed) {

- // Spurious touch acks from the renderer should not trigger a crash.

+ // Spurious asynchronous acks should not trigger a crash.

if (IsEmpty() || (Head().empty() && sequences_.size() == 1))

return;

« ui/aura/window_tree_host.h ('K') | « ui/aura/window_tree_host.h ('k') | ui/events/gestures/gesture_recognizer.h » ('j') | no next file with comments »