Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 503883002: Use number of components from ICC profile and alternate color space (Closed)

Created:
6 years, 4 months ago by Bo Xu
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Use number of components from ICC profile and alternate color space BUG=406806 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1dfbe60

Patch Set 1 : patch from 493163003 #

Patch Set 2 : Resolve comments #

Total comments: 2

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -61 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcodec/fx_codec.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 2 2 chunks +57 lines, -34 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_icc.cpp View 1 8 chunks +39 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bo Xu
Hi Tom, I put the original patch in patch set 1 for comparison and resolve ...
6 years, 4 months ago (2014-08-25 20:27:43 UTC) #1
Tom Sepez
lgtm https://codereview.chromium.org/503883002/diff/60001/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp File core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp (right): https://codereview.chromium.org/503883002/diff/60001/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp#newcode527 core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp:527: m_pTransform = NULL; nit: This assignment becomes redundant ...
6 years, 4 months ago (2014-08-25 20:37:02 UTC) #2
Bo Xu
https://codereview.chromium.org/503883002/diff/60001/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp File core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp (right): https://codereview.chromium.org/503883002/diff/60001/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp#newcode527 core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp:527: m_pTransform = NULL; On 2014/08/25 20:37:02, Tom Sepez wrote: ...
6 years, 4 months ago (2014-08-25 20:43:11 UTC) #3
Bo Xu
6 years, 4 months ago (2014-08-25 20:45:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as 1dfbe60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698