extensions/browser/api/usb_private/usb_private_api.cc - Issue 503873002: Remove implicit conversions from scoped_refptr to T* in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/usb_private/usb_private_api.cc

Issue 503873002: Remove implicit conversions from scoped_refptr to T* in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/usb_private/usb_private_api.cc

diff --git a/extensions/browser/api/usb_private/usb_private_api.cc b/extensions/browser/api/usb_private/usb_private_api.cc

index c09939a82f2adbbdd31d0548c3ad6af2b26ab516..860a13a513f5f47e480bed9ce01587a88ac5c7e1 100644

--- a/extensions/browser/api/usb_private/usb_private_api.cc

+++ b/extensions/browser/api/usb_private/usb_private_api.cc

@@ -125,7 +125,7 @@ void UsbPrivateGetDeviceInfoFunction::AsyncWorkStart() {

scoped_refptr<UsbDevice> device =

service->GetDeviceById(parameters_->device_id);

- if (!device) {

+ if (!device.get()) {

CompleteWithError(kErrorNoDevice);

return;

}

@@ -146,7 +146,7 @@ void UsbPrivateGetDeviceInfoFunction::AsyncWorkStart() {

}

scoped_refptr<UsbDeviceHandle> device_handle = device->Open();

- if (!device_handle) {

+ if (!device_handle.get()) {

CompleteWithError(kErrorOpen);

return;

}

« no previous file with comments | « extensions/browser/api/usb/usb_api.cc ('k') | extensions/browser/extension_function.cc » ('j') | no next file with comments »