Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 503853002: Remove svn code in checkperms.py after the git migration. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove svn code in checkperms.py after the git migration. Committed: https://crrev.com/51c6b19a8cd3c7d089d2eee20ba1be4715914ddf Cr-Commit-Position: refs/heads/master@{#292001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -64 lines) Patch
M tools/checkperms/checkperms.py View 5 chunks +1 line, -64 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
thestig@chromium.org changed reviewers: + phajdan.jr@chromium.org
6 years, 4 months ago (2014-08-25 19:33:21 UTC) #1
Lei Zhang
6 years, 4 months ago (2014-08-25 19:33:22 UTC) #2
Paweł Hajdan Jr.
phajdan.jr@chromium.org changed reviewers: + agable@chromium.org, maruel@chromium.org
6 years, 3 months ago (2014-08-26 14:50:12 UTC) #3
Paweł Hajdan Jr.
Actually is this script still relevant in the post-svn world? Maybe we can just remove ...
6 years, 3 months ago (2014-08-26 14:50:12 UTC) #4
M-A Ruel
On 2014/08/26 14:50:12, Paweł Hajdan Jr. wrote: > Actually is this script still relevant in ...
6 years, 3 months ago (2014-08-26 14:56:13 UTC) #5
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-26 20:27:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/503853002/1
6 years, 3 months ago (2014-08-26 20:28:18 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-26 21:33:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (1) as 51f25b38b9677039515af84e02c1106a9adfdba5
6 years, 3 months ago (2014-08-26 22:25:54 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:46:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51c6b19a8cd3c7d089d2eee20ba1be4715914ddf
Cr-Commit-Position: refs/heads/master@{#292001}

Powered by Google App Engine
This is Rietveld 408576698