Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 503833002: Reimplement deserialization of SkImageFilter's uniqueID. (Closed)

Created:
6 years, 4 months ago by Stephen White
Modified:
6 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org, reed1, bsalomon, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Reimplement deserialization of SkImageFilter's uniqueID. 9fa60d ("Simplify flattening to just write enough ... ") simplified just a tad too much. In particular, it disabled deserialization of SkImageFilter's uniqueID, which in turn caused the failure of SkImageFilter's cache, which caused a large regression in Chrome's SVG filter performance. The medium-term fix is to switch to the new SkRecordDraw SkPicture backend, which will make the unique IDs unnecessary. This change is an "in case of emergecy" CL, in the event that there are problems switching on the new backend in Chrome. For that reason, it's minimalist: only the filters used by Chrome are modified, and whitespace changes are kept to a minimum. In this way, it should be easy to revert once the new backend goes in. Committed: https://skia.googlesource.com/skia/+/5e5f948b6b363dbfc8c076d8ff0c6b8e9ea99958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -117 lines) Patch
M include/core/SkImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkBlurImageFilter.h View 2 chunks +4 lines, -3 lines 0 comments Download
M include/effects/SkColorFilterImageFilter.h View 2 chunks +4 lines, -2 lines 0 comments Download
M include/effects/SkDisplacementMapEffect.h View 2 chunks +4 lines, -2 lines 0 comments Download
M include/effects/SkDropShadowImageFilter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M include/effects/SkLightingImageFilter.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 2 chunks +5 lines, -3 lines 0 comments Download
M include/effects/SkMatrixImageFilter.h View 2 chunks +4 lines, -2 lines 0 comments Download
M include/effects/SkMergeImageFilter.h View 2 chunks +8 lines, -5 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 5 chunks +11 lines, -9 lines 0 comments Download
M include/effects/SkOffsetImageFilter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 1 chunk +6 lines, -6 lines 0 comments Download
M include/effects/SkRectShaderImageFilter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/effects/SkTileImageFilter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M include/effects/SkXfermodeImageFilter.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 10 chunks +19 lines, -16 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/effects/SkMatrixImageFilter.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M src/effects/SkRectShaderImageFilter.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen White
Here's my backup plan, should problems emerge w/the new SkPicture backend. (Just putting it out ...
6 years, 4 months ago (2014-08-25 19:01:11 UTC) #1
reed1
reed@google.com changed reviewers: + reed@google.com
6 years, 3 months ago (2014-08-26 19:12:58 UTC) #2
reed1
lgtm
6 years, 3 months ago (2014-08-26 19:12:58 UTC) #3
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 3 months ago (2014-08-26 19:14:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/503833002/1
6 years, 3 months ago (2014-08-26 19:15:43 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-26 19:27:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 5e5f948b6b363dbfc8c076d8ff0c6b8e9ea99958

Powered by Google App Engine
This is Rietveld 408576698