Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1754)

Unified Diff: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

Issue 503823002: Creates CacheContext for ServiceWorkerCacheStorage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses comments from PS4 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
diff --git a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
index d02dc3d9d6f26db5b71ccde16bd6ece3c01409b3..b46c90a9444999adbb075325e6ea2a57dfb3f64f 100644
--- a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
+++ b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
@@ -92,9 +92,9 @@ class ServiceWorkerCacheStorageManagerTest : public testing::Test {
bool error = callback_error_ !=
ServiceWorkerCacheStorage::CACHE_STORAGE_ERROR_NO_ERROR;
if (error)
- EXPECT_EQ(0, callback_cache_id_);
+ EXPECT_EQ(ServiceWorkerCacheStorage::kInvalidCacheID, callback_cache_id_);
else
- EXPECT_LT(0, callback_cache_id_);
+ EXPECT_LE(0, callback_cache_id_);
return !error;
}
@@ -111,9 +111,9 @@ class ServiceWorkerCacheStorageManagerTest : public testing::Test {
bool error = callback_error_ !=
ServiceWorkerCacheStorage::CACHE_STORAGE_ERROR_NO_ERROR;
if (error)
- EXPECT_EQ(0, callback_cache_id_);
+ EXPECT_EQ(ServiceWorkerCacheStorage::kInvalidCacheID, callback_cache_id_);
else
- EXPECT_LT(0, callback_cache_id_);
+ EXPECT_LE(0, callback_cache_id_);
return !error;
}
@@ -181,7 +181,7 @@ class ServiceWorkerCacheStorageManagerTest : public testing::Test {
scoped_ptr<ServiceWorkerCacheStorageManager> cache_manager_;
int callback_bool_;
- int callback_cache_id_;
+ ServiceWorkerCacheStorage::CacheID callback_cache_id_;
ServiceWorkerCacheStorage::CacheStorageError callback_error_;
std::vector<std::string> callback_strings_;
@@ -223,6 +223,14 @@ TEST_P(ServiceWorkerCacheStorageManagerTestP, CreateTwoCaches) {
EXPECT_TRUE(CreateCache(origin1_, "bar"));
}
+TEST_P(ServiceWorkerCacheStorageManagerTestP, IDsDiffer) {
+ EXPECT_TRUE(CreateCache(origin1_, "foo"));
+ ServiceWorkerCacheStorage::CacheID id1 = callback_cache_id_;
+ EXPECT_TRUE(CreateCache(origin1_, "bar"));
+ ServiceWorkerCacheStorage::CacheID id2 = callback_cache_id_;
+ EXPECT_NE(id1, id2);
+}
+
TEST_P(ServiceWorkerCacheStorageManagerTestP, Create2CachesSameNameDiffSWs) {
EXPECT_TRUE(CreateCache(origin1_, "foo"));
EXPECT_TRUE(CreateCache(origin2_, "foo"));

Powered by Google App Engine
This is Rietveld 408576698