content/browser/service_worker/service_worker_cache_listener.cc - Issue 503823002: Creates CacheContext for ServiceWorkerCacheStorage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_cache_listener.cc

Issue 503823002: Creates CacheContext for ServiceWorkerCacheStorage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses comments from PS4 Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_cache_listener.cc

diff --git a/content/browser/service_worker/service_worker_cache_listener.cc b/content/browser/service_worker/service_worker_cache_listener.cc

index 5c44a09a7b8d0d4e70036e4fa7027e34e29b635a..d20c7e511b5f171c8fa4125c76be05ca92b5b056 100644

--- a/content/browser/service_worker/service_worker_cache_listener.cc

+++ b/content/browser/service_worker/service_worker_cache_listener.cc

@@ -40,6 +40,10 @@ WebServiceWorkerCacheError ToWebServiceWorkerCacheError(

// TODO(jkarlin): Update this to CACHE_STORAGE_ERROR_EMPTY_KEY once that's

// added.

return WebServiceWorkerCacheError::WebServiceWorkerCacheErrorNotFound;

+ case ServiceWorkerCacheStorage::CACHE_STORAGE_ERROR_CLOSING:

+ // TODO(jkarlin): Update this to CACHE_STORAGE_ERROR_CLOSING once that's

+ // added.

+ return WebServiceWorkerCacheError::WebServiceWorkerCacheErrorNotFound;

}

NOTREACHED();

return WebServiceWorkerCacheError::WebServiceWorkerCacheErrorNotImplemented;