Fix AutoRoll after Git transition

Fix AutoRoll after Git transition

BUG=406867
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291606

[eseidel, 2014-08-25 18:07:28]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2014-08-25 18:07:29]

If we land this, shoudl we just remove safely-roll-blink/safely-roll-deps?

[eseidel, 2014-08-25 18:09:02]

https://codereview.chromium.org/503813002/diff/20001/scripts/tools/blink_roll...
File scripts/tools/blink_roller/auto_roll.py (right):

https://codereview.chromium.org/503813002/diff/20001/scripts/tools/blink_roll...
scripts/tools/blink_roller/auto_roll.py:281: subprocess2.check_call(['roll-dep',
self._path_to_project,
This assumes depot_tools is in the path. Unsure if that's "safe". :)

[borenet, 2014-08-25 18:13:28]

On 2014/08/25 18:07:29, eseidel wrote:
> If we land this, shoudl we just remove safely-roll-blink/safely-roll-deps?

I hadn't heard about depot_tools' roll-dep until last week.  If that's the Way
of the Future, then we might as well remove the old roll scripts.  Really, it'd
be nice if depot_tools could wrap up all of the
clean/branch/roll-dep/commit/upload for us, so that the AutoRoll Bot could focus
purely on managing CLs.  On top of that, it'd be nice if we didn't have to parse
the DEPS file at all here.  A little bit of extra functionality in roll-dep (or
another tiny tool) would take care of that for us:

$ roll-dep --show third_party/WebKit
04b6022fdfb31a848d67683b58cd785aaeba9a69

... And then there's all of the cleanup we should be able to do here now that we
don't have to care about the SVN path.

[borenet, 2014-08-25 18:20:21]

https://codereview.chromium.org/503813002/diff/20001/scripts/tools/blink_roll...
File scripts/tools/blink_roller/auto_roll.py (right):

https://codereview.chromium.org/503813002/diff/20001/scripts/tools/blink_roll...
scripts/tools/blink_roller/auto_roll.py:281: subprocess2.check_call(['roll-dep',
self._path_to_project,
On 2014/08/25 18:09:01, eseidel wrote:
> This assumes depot_tools is in the path. Unsure if that's "safe". :)

I think it's okay since we import find_depot_tools, which adds the depot_tools
path to sys.path.

[eseidel, 2014-08-25 18:20:48]

eseidel@chromium.org changed reviewers:
+ szager@chromium.org

[eseidel, 2014-08-25 18:20:49]

Regardless.  lgtm.  Ideally we'd have szager's opinion as well.

[borenet, 2014-08-25 18:21:28]

borenet@google.com changed reviewers:
+ maruel@chromium.org

[borenet, 2014-08-25 18:21:28]

Yeah, forgot to publish.

[szager1, 2014-08-25 18:28:01]

lgtm

https://codereview.chromium.org/503813002/diff/20001/scripts/tools/blink_roll...
File scripts/tools/blink_roller/auto_roll.py (right):

https://codereview.chromium.org/503813002/diff/20001/scripts/tools/blink_roll...
scripts/tools/blink_roller/auto_roll.py:281: subprocess2.check_call(['roll-dep',
self._path_to_project,
On 2014/08/25 18:09:01, eseidel wrote:
> This assumes depot_tools is in the path. Unsure if that's "safe". :)

It's in depot_tools, which is always in PATH.  But the module is already
import-able, so you could:

import roll_dep
...
roll_dep.main(self._path_to_project, new_roll_revision)

I'm fine either way.

[borenet, 2014-08-25 18:40:24]

https://codereview.chromium.org/503813002/diff/20001/scripts/tools/blink_roll...
File scripts/tools/blink_roller/auto_roll.py (right):

https://codereview.chromium.org/503813002/diff/20001/scripts/tools/blink_roll...
scripts/tools/blink_roller/auto_roll.py:281: subprocess2.check_call(['roll-dep',
self._path_to_project,
On 2014/08/25 18:28:00, szager1 wrote:
> On 2014/08/25 18:09:01, eseidel wrote:
> > This assumes depot_tools is in the path. Unsure if that's "safe". :)
> 
> It's in depot_tools, which is always in PATH.  But the module is already
> import-able, so you could:
> 
> import roll_dep
> ...
> roll_dep.main(self._path_to_project, new_roll_revision)
> 
> I'm fine either way.

I think I'd rather leave it as-is, since the auto_roll_test would suddenly start
to care about the internals of roll_dep as well.

[borenet, 2014-08-25 18:40:28]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-08-25 18:40:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/borenet@google.com/503813002/20001

[commit-bot: I haz the power, 2014-08-25 18:41:58]

Committed patchset #2 (20001) as 291606