Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Issue 503783002: Remove registration in toolbar_view.cc for unused notification. (Closed)

Created:
6 years, 4 months ago by robertshield
Modified:
6 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, MAD
Project:
chromium
Visibility:
Public.

Description

Remove registration in toolbar_view.cc for unused notification. This was causing a DCHECK as ToolbarView::Observe both didn't handle the asked-for notification and DCHECKed on unhandled notification types. BUG=407124 TEST=NONE Committed: https://crrev.com/2fa6c2ffe35e700a4529e1119954dc60faccf708 Cr-Commit-Position: refs/heads/master@{#291823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
robertshield
Hi Peter, I hit a DCHECK for what appears to be an unused notification in ...
6 years, 4 months ago (2014-08-25 15:16:51 UTC) #1
Peter Kasting
LGTM
6 years, 4 months ago (2014-08-25 18:51:16 UTC) #2
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 4 months ago (2014-08-25 21:01:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/503783002/1
6 years, 4 months ago (2014-08-25 21:01:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-25 22:31:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 23:21:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/2718)
6 years, 4 months ago (2014-08-25 23:21:04 UTC) #7
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 4 months ago (2014-08-26 02:11:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/503783002/1
6 years, 4 months ago (2014-08-26 02:12:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (1) as 637a242848bda9364a97072f233c2696d9aa492e
6 years, 4 months ago (2014-08-26 02:52:39 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:39:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fa6c2ffe35e700a4529e1119954dc60faccf708
Cr-Commit-Position: refs/heads/master@{#291823}

Powered by Google App Engine
This is Rietveld 408576698