Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 503733002: X87: Remove KeyedStoreIC::GenerateRuntimeSetProperty and move Store::GenerateRuntimeSetProperty to … (Closed)

Created:
6 years, 4 months ago by chunyang.dai
Modified:
6 years, 4 months ago
Reviewers:
Weiliang, Toon Verwaest
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Remove KeyedStoreIC::GenerateRuntimeSetProperty and move Store::GenerateRuntimeSetProperty to the PropertyICCompiler port r23311. original commit message: Remove KeyedStoreIC::GenerateRuntimeSetProperty and move Store::GenerateRuntimeSetProperty to the PropertyICCompiler x BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -35 lines) Patch
M src/ic/x87/ic-compiler-x87.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 3 chunks +2 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
chunyang.dai
weiliang & Toon. please review and commit this patch. thanks.
6 years, 4 months ago (2014-08-25 09:29:56 UTC) #1
Toon Verwaest
lgtm
6 years, 4 months ago (2014-08-25 09:54:29 UTC) #2
Weiliang
lgtm
6 years, 4 months ago (2014-08-25 09:56:30 UTC) #3
Weiliang
6 years, 4 months ago (2014-08-25 09:57:56 UTC) #4
Committed as r23344

Powered by Google App Engine
This is Rietveld 408576698