content/renderer/media/webrtc_local_audio_renderer.cc - Issue 503683003: Remove implicit conversions from scoped_refptr to T* in content/renderer/media/webrtc*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_local_audio_renderer.cc

Issue 503683003: Remove implicit conversions from scoped_refptr to T* in content/renderer/media/webrtc* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc_audio_renderer_unittest.cc ('k') | content/renderer/media/webrtc_local_audio_source_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_local_audio_renderer.cc

diff --git a/content/renderer/media/webrtc_local_audio_renderer.cc b/content/renderer/media/webrtc_local_audio_renderer.cc

index addf9637a5ff68964a0cdfc471433d028de5981e..ac44a210be3a655320f58b3219838cef2eb2c077 100644

--- a/content/renderer/media/webrtc_local_audio_renderer.cc

+++ b/content/renderer/media/webrtc_local_audio_renderer.cc

@@ -153,7 +153,7 @@ void WebRtcLocalAudioRenderer::Stop() {

// Stop the output audio stream, i.e, stop asking for data to render.

// It is safer to call Stop() on the |sink_| to clean up the resources even

// when the |sink_| is never started.

- if (sink_) {

+ if (sink_.get()) {

sink_->Stop();

sink_ = NULL;

}

@@ -316,7 +316,7 @@ void WebRtcLocalAudioRenderer::ReconfigureSink(

loopback_fifo_.reset(new_fifo);

}

- if (!sink_)

+ if (!sink_.get())

return; // WebRtcLocalAudioRenderer has not yet been started.

// Stop |sink_| and re-create a new one to be initialized with different audio