Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 503683003: Remove implicit conversions from scoped_refptr to T* in content/renderer/media/webrtc* (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in content/renderer/media/webrtc* This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/25d7709bb47ae6db7752d3510188a0d5c4539863 Cr-Commit-Position: refs/heads/master@{#292096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -113 lines) Patch
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc View 16 chunks +47 lines, -47 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 11 chunks +14 lines, -16 lines 0 comments Download
M content/renderer/media/webrtc/video_destination_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/video_destination_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_media_stream_adapter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc_audio_renderer_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_renderer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_source_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_local_audio_track.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_track_unittest.cc View 13 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + vrk@chromium.org
6 years, 4 months ago (2014-08-25 23:09:35 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 4 months ago (2014-08-25 23:09:36 UTC) #2
vrk (LEFT CHROMIUM)
The CQ bit was checked by vrk@chromium.org
6 years, 3 months ago (2014-08-27 03:51:00 UTC) #3
vrk (LEFT CHROMIUM)
lgtm
6 years, 3 months ago (2014-08-27 03:51:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/503683003/1
6 years, 3 months ago (2014-08-27 03:52:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 2c7d8626214af2690481974f5bf4926d4de592f9
6 years, 3 months ago (2014-08-27 04:29:21 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:49:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25d7709bb47ae6db7752d3510188a0d5c4539863
Cr-Commit-Position: refs/heads/master@{#292096}

Powered by Google App Engine
This is Rietveld 408576698