LayoutTests/fast/events/scale-document.html - Issue 503583002: Fixed Inconsistent behaviour of custom-scrollbar

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/scale-document.html

Issue 503583002: Fixed Inconsistent behaviour of custom-scrollbar (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding test case Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	esprehn 2014/09/19 05:06:52 missing doctype, also leave out the html, body and missing doctype, also leave out the html, body and head elements. MuVen 2014/09/19 16:19:29 Done. Show quoted text On 2014/09/19 05:06:52, esprehn wrote: > missing doctype, also leave out the html, body and head elements. Done.
	2 <head>

	3 <style>

	4 ::-webkit-scrollbar {

	5 height: 16px;
	esprehn 2014/09/19 05:06:52 Does height actually do anything here? Does height actually do anything here? MuVen 2014/09/19 16:19:29 Nothing like that, i see issue with height and wid Nothing like that, i see issue with height and width 1px even. On 2014/09/19 05:06:52, esprehn wrote: Show quoted text > Does height actually do anything here?
	6 overflow: visible;
	esprehn 2014/09/19 05:06:52 overflow doesn't do anything on a scrollbar. overflow doesn't do anything on a scrollbar. MuVen 2014/09/19 16:19:29 Done. Show quoted text On 2014/09/19 05:06:52, esprehn wrote: > overflow doesn't do anything on a scrollbar. Done.
	7 width: 16px

	8 }

	9 html {

	10 overflow-y: scroll

	11 }

	12 </style>

	13 <script>

	14 function test() {

	15 // The factors are the same as those in Chrome settings.
	esprehn 2014/09/19 05:06:52 just inline this code below, remove the function. just inline this code below, remove the function. MuVen 2014/09/19 16:19:30 Done. Show quoted text On 2014/09/19 05:06:52, esprehn wrote: > just inline this code below, remove the function. Done.
	16 var zoomFactors = [1, 1.1, 1.25, 1.5, 1.75, 2, 2.5, 3, 4, 5];

	17 if (!window.eventSender)

	18 return;

	19 for (i = 0; i < zoomFactors.length; ++i)

	20 eventSender.setPageZoomFactor(zoomFactors[i]);

	21

	22 if (window.testRunner)
	esprehn 2014/09/19 05:06:52 bad indent. bad indent. MuVen 2014/09/19 16:19:30 Done. Show quoted text On 2014/09/19 05:06:52, esprehn wrote: > bad indent. Done.
	23 testRunner.notifyDone();

	24 }

	25

	26 if (window.testRunner) {
	esprehn 2014/09/19 05:06:52 bad indentation. bad indentation. MuVen 2014/09/19 16:19:30 Done. Show quoted text On 2014/09/19 05:06:52, esprehn wrote: > bad indentation. Done.
	27 testRunner.dumpAsText();

	28 testRunner.waitUntilDone();

	29 }

	30 test();

	31 </script>

	32 </head>

	33 <body>

	34 <div>

	35 Test for Reproducible crash in FrameView::layout(bool allowSubtree).

	36 </div>

	37 <div>

	38 The test passed if it did not crash.

	39 </div>

	40 <ul>

	41 <li>Chrome did not crash</li>

	42 <li>Chrome did not crash</li>

	43 <li>Chrome did not crash</li>

	44 <li>Chrome did not crash</li>

	45 <li>Chrome did not crash</li>

	46 <li>Chrome did not crash</li>

	47 <li>Chrome did not crash</li>

	48 <li>Chrome did not crash</li>

	49 <li>Chrome did not crash</li>

	50 <li>Chrome did not crash</li>

	51 </ul>

	52 </body>

	53 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/scale-document-expected.txt » ('j') | Source/core/frame/FrameView.cpp » ('J')