Issue 503563002: Auto-update .gclient files for git.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 503563002: Auto-update .gclient files for git. (Closed)

Created:
6 years, 4 months ago by szager1

Modified:
6 years, 3 months ago

Reviewers:
iannucci, ghost stip (do not use)

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Project:
tools

Visibility:
Public.

More Reviews

Description

Auto-update .gclient files for git. TBR=iannucci@chromium.org,stip@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291567

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -5 lines)			Patch
	M	gclient.py	View		7 chunks	+130 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

andresp-chromium

6 years, 3 months ago (2014-08-28 12:10:49 UTC) #2

Message was sent while issue was closed.

On 2014/08/23 00:57:34, szager1 wrote:
> Committed patchset #1 manually as 291567.

This CL has broken running gclient sync on non-trivial .gclients (e.g. there is
an Import directive on the gclient).

I uploaded a patch with a suggested fix:
https://codereview.chromium.org/513923006
But adding a flag that disables this check would also be fine for me.

Expand Messages | Collapse Messages