Issue 503383003: Use libaddressinput revision 334.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 503383003: Use libaddressinput revision 334. (Closed)

Created:
6 years, 3 months ago by please use gerrit instead

Modified:
6 years, 3 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, roubert, Nico

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use libaddressinput revision 334. Previous revision is 333. Revision 334 fixes a clang warning about writing timestamps into strings with "%ld" on systems that use 64-bit time. The fix is a static cast of the timestamp into long. This will be fine until 2037. TBR=estade@chromium.org Committed: https://crrev.com/1492454dde1f9f1c82513c28d0638f3af734edda Cr-Commit-Position: refs/heads/master@{#291946}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	DEPS	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	third_party/libaddressinput/README.chromium	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

please use gerrit instead

The CQ bit was checked by rouslan@chromium.org

6 years, 3 months ago (2014-08-26 17:31:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/503383003/1

6 years, 3 months ago (2014-08-26 17:32:37 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (1) as ee00f886baf4c4975216c9584976b1a653432603

6 years, 3 months ago (2014-08-26 18:36:31 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:44:15 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1492454dde1f9f1c82513c28d0638f3af734edda
Cr-Commit-Position: refs/heads/master@{#291946}

Expand Messages | Collapse Messages