ash/shell_window_ids.h - Issue 503383002: Allow component IME extension use app.window and add 'ime' window type for app window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell_window_ids.h

Issue 503383002: Allow component IME extension use app.window and add 'ime' window type for app window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and init the window with correct parent instead of reparent afterwards Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/shell_unittest.cc ('k') | chrome/browser/extensions/api/app_window/app_window_api.cc » ('j') | chrome/browser/extensions/api/app_window/app_window_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/shell_window_ids.h

diff --git a/ash/shell_window_ids.h b/ash/shell_window_ids.h

index f01e74b3715b26eb78026c7da16ca4a8355a2b94..4e3f49dc770401face3122429945232cb1751988 100644

--- a/ash/shell_window_ids.h

+++ b/ash/shell_window_ids.h

@@ -90,10 +90,10 @@ const int kShellWindowId_OverlayContainer = 21;

// ID of the window created by PhantomWindowController or DragWindowController.

const int kShellWindowId_PhantomWindow = 22;

-// A parent container that holds the virtual keyboard container. This is to

-// ensure that the virtual keyboard is stacked above most containers but below

-// the mouse cursor and the power off animation.

-const int kShellWindowId_VirtualKeyboardParentContainer = 23;

+// A parent container that holds the virtual keyboard container and ime windows

+// if any. This is to ensure that the virtual keyboard or ime window is stacked

+// above most containers but below the mouse cursor and the power off animation.

+const int kShellWindowId_ImeWindowParentContainer = 23;

// The container for mouse cursor.

const int kShellWindowId_MouseCursorContainer = 24;