extensions/browser/app_window/app_window.h - Issue 503383002: Allow component IME extension use app.window and add 'ime' window type for app window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.h

Issue 503383002: Allow component IME extension use app.window and add 'ime' window type for app window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reviews Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/app_window/app_window_api.cc ('K') | « chrome/test/data/extensions/platform_apps/windows_api_ime/no_permissions_whitelisted/manifest.json ('k') | extensions/browser/app_window/app_window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/app_window/app_window.h

diff --git a/extensions/browser/app_window/app_window.h b/extensions/browser/app_window/app_window.h

index f3b8e6ecbc4fbd9682f599b3a9954002dc86a676..02f2c735a04a2e4e3a635fd25ee66d2c9417fdb6 100644

--- a/extensions/browser/app_window/app_window.h

+++ b/extensions/browser/app_window/app_window.h

@@ -150,6 +150,7 @@ class AppWindow : public content::NotificationObserver,

SkColor active_frame_color;

SkColor inactive_frame_color;

bool alpha_enabled;

+ bool is_ime_window;

jackhou1 2014/09/15 03:49:33 I think you can remove this too if it's not used a

bshe 2014/09/16 12:44:56 This is still used in app_window_api.cc to remembe

// The initial content/inner bounds specification (excluding any window

// decorations).