Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/renderer/resources/extensions/app_window_custom_bindings.js

Issue 503383002: Allow component IME extension use app.window and add 'ime' window type for app window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/app_window_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/app_window_custom_bindings.js b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
index 812d3d6c6af54474773bc45892310b9ce48314e4..27869c39a71b6080fdf961e6133cc5faa012a8b0 100644
--- a/chrome/renderer/resources/extensions/app_window_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
@@ -244,6 +244,9 @@ appWindow.registerCustomHook(function(bindingsAPI) {
AppWindow.prototype.alphaEnabled = function() {
return appWindowData.alphaEnabled;
};
+ AppWindow.prototype.isImeWindow = function() {
+ return appWindowData.isImeWindow;
+ };
AppWindow.prototype.handleWindowFirstShownForTests = function(callback) {
// This allows test apps to get have their callback run even if they
// call this after the first show has happened.
@@ -305,7 +308,8 @@ appWindow.registerCustomHook(function(bindingsAPI) {
hasFrameColor: params.hasFrameColor,
activeFrameColor: params.activeFrameColor,
inactiveFrameColor: params.inactiveFrameColor,
- alphaEnabled: params.alphaEnabled
+ alphaEnabled: params.alphaEnabled,
+ isImeWindow: params.isImeWindow
};
currentAppWindow = new AppWindow;
});
@@ -398,4 +402,4 @@ function updateSizeConstraints(boundsType, constraints) {
exports.binding = appWindow.generate();
exports.onAppWindowClosed = onAppWindowClosed;
exports.updateAppWindowProperties = updateAppWindowProperties;
-exports.appWindowShownForTests = onAppWindowShownForTests;
+exports.appWindowShownForTests = onAppWindowShownForTests;

Powered by Google App Engine
This is Rietveld 408576698