Allow component IME extension use app.window and add 'ime' window type for app window

chrome/browser/extensions/api/app_window/app_window_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/app_window/app_window_api.h"
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/time/time.h"
@@ skipping 38 matching lines @@
 const char kAlwaysOnTopPermission[] =
     "The \"app.window.alwaysOnTop\" permission is required.";
 const char kInvalidUrlParameter[] =
     "The URL used for window creation must be local for security reasons.";
 const char kAlphaEnabledWrongChannel[] =
     "The alphaEnabled option requires dev channel or newer.";
 const char kAlphaEnabledMissingPermission[] =
     "The alphaEnabled option requires app.window.alpha permission.";
 const char kAlphaEnabledNeedsFrameNone[] =
     "The alphaEnabled option can only be used with \"frame: 'none'\".";
+const char kImeWindowMissingPermission[] =
+    "The ime option requires app.window.ime permission.";
+const char kImeWindowNeedsFrameNone[] =
+    "The ime option can only be used with \"frame: 'none'\".";
+#if !defined(OS_CHROMEOS)
+const char kImeWindowUnsupportedPlatform[] =
+    "The ime option can only be used on ChromeOS.";
+#endif
 }  // namespace app_window_constants
 
 const char kNoneFrameOption[] = "none";
   // TODO(benwells): Remove HTML titlebar injection.
 const char kHtmlFrameOption[] = "experimental-html";
 
 namespace {
 
 // If the same property is specified for the inner and outer bounds, raise an
 // error.
@@ skipping 127 matching lines @@
     if (!AppsClient::Get()->IsCurrentChannelOlderThanDev() ||
         extension()->location() == extensions::Manifest::COMPONENT) {
       if (options->type == extensions::api::app_window::WINDOW_TYPE_PANEL) {
         create_params.window_type = AppWindow::WINDOW_TYPE_PANEL;
       }
     }
 
     if (!GetFrameOptions(*options, &create_params))
       return false;
 
+    if (options->ime.get()) {

[benwells, 2014/09/11 19:35:10]

It is important that non-app extensions MUST specify this, but that doesn't seem
to be enforced in any way.

There needs to be a check after this that if the extension isn't a packaged app
that create_params.is_ime_window is true. This also needs to be tested. 

[bshe, 2014/09/11 22:35:59]

I see what you mean. I thought whitelist is enough.

In the latest patch:
1. if platform app set ime option, we will give an error;
2. if extension didn't set ime option, we will give an error;

And the two new cases are tested.


On 2014/09/11 19:35:10, benwells (OOO until October 7) wrote:

+#if defined(OS_CHROMEOS)
+      if (!extension()->permissions_data()->HasAPIPermission(
+              APIPermission::kImeWindowEnabled)) {
+        error_ = app_window_constants::kImeWindowMissingPermission;
+        return false;
+      }
+      if (create_params.frame != AppWindow::FRAME_NONE) {
+        error_ = app_window_constants::kImeWindowNeedsFrameNone;
+        return false;
+      }
+      create_params.is_ime_window = *options->ime;
+#else
+      // IME window is only supported on ChromeOS.
+      error_ = app_window_constants::kImeWindowUnsupportedPlatform;
+      return false;
+#endif
+    }
+
     if (options->alpha_enabled.get()) {
       const char* whitelist[] = {
         "0F42756099D914A026DADFA182871C015735DD95",  // http://crbug.com/323773
         "2D22CDB6583FD0A13758AEBE8B15E45208B4E9A7",
         "E7E2461CE072DF036CF9592740196159E2D7C089",  // http://crbug.com/356200
         "A74A4D44C7CFCD8844830E6140C8D763E12DD8F3",
         "312745D9BF916161191143F6490085EEA0434997",
         "53041A2FA309EECED01FFC751E7399186E860B2C"
       };
       if (AppsClient::Get()->IsCurrentChannelOlderThanDev() &&
@@ skipping 272 matching lines @@
 
   if (options.frame->as_frame_options->inactive_color.get()) {
     error_ = app_window_constants::kInactiveColorWithoutColor;
     return false;
   }
 
   return true;
 }
 
 }  // namespace extensions