Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: runtime/vm/heap.cc

Issue 503363005: - Add and enable concurrent sweeper. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/gc_sweeper.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/heap.cc
===================================================================
--- runtime/vm/heap.cc (revision 39573)
+++ runtime/vm/heap.cc (working copy)
@@ -8,6 +8,7 @@
#include "platform/utils.h"
#include "vm/flags.h"
#include "vm/isolate.h"
+#include "vm/lockers.h"
#include "vm/object.h"
#include "vm/object_set.h"
#include "vm/os.h"
@@ -80,16 +81,44 @@
uword Heap::AllocateOld(intptr_t size, HeapPage::PageType type) {
ASSERT(isolate()->no_gc_scope_depth() == 0);
uword addr = old_space_->TryAllocate(size, type);
- if (addr == 0) {
- CollectAllGarbage();
- addr = old_space_->TryAllocate(size, type, PageSpace::kForceGrowth);
- if (addr == 0) {
- OS::PrintErr("Exhausted heap space, trying to allocate %" Pd " bytes.\n",
- size);
- return 0;
+ if (addr != 0) {
+ return addr;
+ }
+ // If we are in the process of running a sweep wait for the sweeper to free
+ // memory.
+ {
+ MonitorLocker ml(old_space_->tasks_lock());
+ addr = old_space_->TryAllocate(size, type);
+ while ((addr == 0) && (old_space_->tasks())) {
+ ml.Wait();
+ addr = old_space_->TryAllocate(size, type);
}
}
- return addr;
+ if (addr != 0) {
+ return addr;
+ }
+ // All GC tasks finished without allocating successfully. Run a full GC.
+ CollectAllGarbage();
+ addr = old_space_->TryAllocate(size, type, PageSpace::kForceGrowth);
+ if (addr != 0) {
+ return addr;
+ }
+ // Wait for all of the concurrent tasks to finish before giving up.
+ {
+ MonitorLocker ml(old_space_->tasks_lock());
+ addr = old_space_->TryAllocate(size, type);
+ while ((addr == 0) && (old_space_->tasks())) {
+ ml.Wait();
+ addr = old_space_->TryAllocate(size, type);
koda 2014/08/27 05:42:20 Shouldn't this have kForceGrowth?
+ }
+ }
+ if (addr != 0) {
+ return addr;
+ }
+ // Giving up allocating this object.
+ OS::PrintErr(
+ "Exhausted heap space, trying to allocate %" Pd " bytes.\n", size);
+ return 0;
}
void Heap::AllocateExternal(intptr_t size, Space space) {
« no previous file with comments | « runtime/vm/gc_sweeper.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698