Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 503363004: Remove redundant echo.mojom, verify non-nullables in echo_service.mojom (Closed)

Created:
6 years, 3 months ago by Chris Masone
Modified:
6 years, 3 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove redundant echo.mojom, verify non-nullables in echo_service.mojom While looking at mojom files I'm nominally the owner of, I realized that one had become redundant. So, I just deleted it and checked the other to make sure it had the right 'nullability' on the method args. Also moved around code to build against the de-duped mojom file. BUG=407673 TEST=build with gyp and gn Committed: https://crrev.com/0e989ee10367671221add030b0cb55e42311faf1 Cr-Commit-Position: refs/heads/master@{#292054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -135 lines) Patch
M mojo/examples/dbus_echo/dbus_echo_app.cc View 3 chunks +2 lines, -2 lines 0 comments Download
A + mojo/examples/dbus_echo/dbus_echo_service.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 chunk +19 lines, -1 line 0 comments Download
M mojo/mojo_services.gypi View 2 chunks +0 lines, -36 lines 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/services/dbus_echo/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/dbus_echo/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/services/dbus_echo/dbus_echo_service.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/services/dbus_echo/echo.mojom View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Chris Masone
cmasone@chromium.org changed reviewers: + yzshen@chromium.org
6 years, 3 months ago (2014-08-26 20:40:19 UTC) #1
Chris Masone
PTAL
6 years, 3 months ago (2014-08-26 20:40:19 UTC) #2
yzshen1
LGTM Thanks!
6 years, 3 months ago (2014-08-26 23:24:30 UTC) #3
Chris Masone
The CQ bit was checked by cmasone@chromium.org
6 years, 3 months ago (2014-08-26 23:29:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmasone@chromium.org/503363004/1
6 years, 3 months ago (2014-08-26 23:33:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as cdc160da131724198be79a69e4b2ccabbb533589
6 years, 3 months ago (2014-08-27 00:32:20 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e989ee10367671221add030b0cb55e42311faf1
Cr-Commit-Position: refs/heads/master@{#292054}

Powered by Google App Engine
This is Rietveld 408576698