Issue 503353002: Remove implicit conversions from scoped_refptr to T* in components/invalidation/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 503353002: Remove implicit conversions from scoped_refptr to T* in components/invalidation/ (Closed)

Created:
6 years, 3 months ago by dcheng

Modified:
6 years, 3 months ago

Reviewers:
nyquist

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove implicit conversions from scoped_refptr to T* in components/invalidation/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/f0fe8bfcf912d3a1cfe0d8a8d2a5629a70704651 Cr-Commit-Position: refs/heads/master@{#292191}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	components/invalidation/gcm_network_channel.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/invalidation/invalidation.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/invalidation/non_blocking_invalidator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/invalidation/sync_invalidation_listener.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dcheng

dcheng@chromium.org changed reviewers: + nyquist@chromium.org

6 years, 3 months ago (2014-08-26 16:24:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/503353002/1

6 years, 3 months ago (2014-08-27 17:38:02 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as a755e2724f602f569a2ba849603a5cc6485ce229

6 years, 3 months ago (2014-08-27 18:32:55 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:52:57 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f0fe8bfcf912d3a1cfe0d8a8d2a5629a70704651
Cr-Commit-Position: refs/heads/master@{#292191}

Expand Messages | Collapse Messages