Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 503293003: Remove a TODO which is no longer applicable. (Closed)

Created:
6 years, 3 months ago by eroman
Modified:
6 years, 3 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove a TODO which is no longer applicable. Committed: https://crrev.com/6ffa460795883b37e986161d8a8e6afc6cadb6f9 Cr-Commit-Position: refs/heads/master@{#292206}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/child/webcrypto/test/hmac_unittest.cc View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 10 (0 generated)
eroman
eroman@chromium.org changed reviewers: + rsleevi@chromium.org
6 years, 3 months ago (2014-08-26 18:13:05 UTC) #1
eroman
https://codereview.chromium.org/503293003/diff/1/content/child/webcrypto/test/hmac_unittest.cc File content/child/webcrypto/test/hmac_unittest.cc (left): https://codereview.chromium.org/503293003/diff/1/content/child/webcrypto/test/hmac_unittest.cc#oldcode39 content/child/webcrypto/test/hmac_unittest.cc:39: // TODO(padolph): Missing known answer tests for HMAC SHA384, ...
6 years, 3 months ago (2014-08-26 18:13:05 UTC) #2
Ryan Sleevi
lgtm
6 years, 3 months ago (2014-08-27 17:11:40 UTC) #3
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 3 months ago (2014-08-27 17:15:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/503293003/1
6 years, 3 months ago (2014-08-27 17:16:48 UTC) #5
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 3 months ago (2014-08-27 17:33:55 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 3 months ago (2014-08-27 19:29:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/503293003/1
6 years, 3 months ago (2014-08-27 19:30:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as a59f067d649075070eaf26112c5ae44781434e19
6 years, 3 months ago (2014-08-27 19:31:47 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:30 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ffa460795883b37e986161d8a8e6afc6cadb6f9
Cr-Commit-Position: refs/heads/master@{#292206}

Powered by Google App Engine
This is Rietveld 408576698