Add AppDelegate::ResizeWebContents

Add AppDelegate::ResizeWebContents

To stop directly depending on apps/window_size_sizer from AppWindow.

BUG=403726
TBR=cbentzel@chromium.org for include/namespace fix in chrome/browser/prerender/prerender_contents.cc

Committed: https://crrev.com/bf20fc68e55897d1caed421fe371d2ad83dd4e34
Cr-Commit-Position: refs/heads/master@{#292091}

[hashimoto, 2014-08-26 03:58:30]

hashimoto@chromium.org changed reviewers:
+ benwells@chromium.org

[benwells, 2014-08-26 07:24:04]

I'd like to also move the resizer file out of apps/, as now only stuff in chrome
needs it.

Could you move it to somewhere like c/b/ui?

[hashimoto, 2014-08-26 07:38:05]

On 2014/08/26 07:24:04, benwells wrote:
> I'd like to also move the resizer file out of apps/, as now only stuff in
chrome
> needs it.
> 
> Could you move it to somewhere like c/b/ui?

Done.
Uploaded a new patch which also moves the resizer to c/b/ui.

[benwells, 2014-08-26 08:33:34]

lgtm but you'll need some owners...

https://codereview.chromium.org/503233003/diff/20001/chrome/browser/prerender...
File chrome/browser/prerender/prerender_contents.cc (right):

https://codereview.chromium.org/503233003/diff/20001/chrome/browser/prerender...
chrome/browser/prerender/prerender_contents.cc:336:
chrome::ResizeWebContents(prerender_contents_.get(), size_);
I didn't think the chrome:: namespace was supposed to be used any more.

[hashimoto, 2014-08-26 08:48:58]

hashimoto@chromium.org changed reviewers:
+ pkasting@chromium.org

[hashimoto, 2014-08-26 08:48:58]

Peter, could you review this change as an owner of chrome/browser/ui?

https://codereview.chromium.org/503233003/diff/20001/chrome/browser/prerender...
File chrome/browser/prerender/prerender_contents.cc (right):

https://codereview.chromium.org/503233003/diff/20001/chrome/browser/prerender...
chrome/browser/prerender/prerender_contents.cc:336:
chrome::ResizeWebContents(prerender_contents_.get(), size_);
On 2014/08/26 08:33:34, benwells wrote:
> I didn't think the chrome:: namespace was supposed to be used any more.

Stopped using chrome namespace.

[Peter Kasting, 2014-08-26 18:05:06]

https://codereview.chromium.org/503233003/diff/40001/chrome/browser/ui/apps/c...
File chrome/browser/ui/apps/chrome_app_delegate.cc (right):

https://codereview.chromium.org/503233003/diff/40001/chrome/browser/ui/apps/c...
chrome/browser/ui/apps/chrome_app_delegate.cc:182:
ResizeWebContents(web_contents, size);
Won't symbol resolution rules result in this method calling itself?

[hashimoto, 2014-08-27 01:47:15]

https://codereview.chromium.org/503233003/diff/40001/chrome/browser/ui/apps/c...
File chrome/browser/ui/apps/chrome_app_delegate.cc (right):

https://codereview.chromium.org/503233003/diff/40001/chrome/browser/ui/apps/c...
chrome/browser/ui/apps/chrome_app_delegate.cc:182:
ResizeWebContents(web_contents, size);
On 2014/08/26 18:05:06, Peter Kasting wrote:
> Won't symbol resolution rules result in this method calling itself?

Ugh, good catch.
Fixed to call the right function.

[Peter Kasting, 2014-08-27 01:53:55]

LGTM, although I'm not normally a big fan of global methods, especially when
they have identical names and args to non-global methods.

[hashimoto, 2014-08-27 02:28:07]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-27 02:28:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/503233003/60001

[commit-bot: I haz the power, 2014-08-27 03:20:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-27 03:25:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 03:25:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hashimoto, 2014-08-27 03:27:34]

hashimoto@chromium.org changed reviewers:
+ cbentzel@chromium.org

[hashimoto, 2014-08-27 03:27:48]

TBRing cbentzel@chromium.org for include/namespace fix in
chrome/browser/prerender/prerender_contents.cc

[hashimoto, 2014-08-27 03:27:53]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-27 03:28:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/503233003/60001

[commit-bot: I haz the power, 2014-08-27 03:34:14]

Committed patchset #4 (60001) as d125d65f007ec2329ebd2af407012c8a2b9a4610

[commit-bot: I haz the power, 2014-09-10 02:49:31]

Patchset 4 (id:??) landed as
https://crrev.com/bf20fc68e55897d1caed421fe371d2ad83dd4e34
Cr-Commit-Position: refs/heads/master@{#292091}