Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Issue 503183002: Revert, causing browser crashes due to race (Closed)

Created:
6 years, 4 months ago by scottmg
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/8a9ec94f82cb01ad7e7cd0ac8a44f2569f16329d Cr-Commit-Position: refs/heads/master@{#291798}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -38 lines) Patch
M content/browser/renderer_host/media/peer_connection_tracker_host.h View 3 chunks +3 lines, -9 lines 0 comments Download
M content/browser/renderer_host/media/peer_connection_tracker_host.cc View 3 chunks +1 line, -17 lines 0 comments Download
M content/common/media/peer_connection_tracker_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/peer_connection_tracker.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/peer_connection_tracker.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-25 23:37:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/503183002/1
6 years, 4 months ago (2014-08-25 23:38:55 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 00:09:09 UTC) #3
commit-bot: I haz the power
Failed to apply patch for content/renderer/media/peer_connection_tracker.cc: While running git apply --index -p1; error: patch failed: ...
6 years, 4 months ago (2014-08-26 00:09:10 UTC) #4
scottmg
Committed patchset #2 to pending queue manually as 60a8dc5 (presubmit successful).
6 years, 4 months ago (2014-08-26 00:19:47 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:38:54 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a9ec94f82cb01ad7e7cd0ac8a44f2569f16329d
Cr-Commit-Position: refs/heads/master@{#291798}

Powered by Google App Engine
This is Rietveld 408576698