Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1880)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

Issue 50313007: Implement dynamic function checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r30897. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart b/dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
index 276d339c975b0f7655d93cfb3998940b42c551ce..b8e8210ab1136caf110312b00277963789a796ed 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
@@ -322,17 +322,12 @@ class ContainerBuilder extends CodeEmitterHelper {
closureBuilder.addProperty(operatorSignature, encoding);
}
- void emitIsFunctionTypeTest(FunctionType functionType) {
- String operator = namer.operatorIsType(functionType);
- closureBuilder.addProperty(operator, js('true'));
- }
-
FunctionType methodType = element.computeType(compiler);
Map<FunctionType, bool> functionTypeChecks =
task.typeTestEmitter.getFunctionTypeChecksOn(methodType);
task.typeTestEmitter.generateFunctionTypeTests(
element, methodType, functionTypeChecks,
- emitFunctionTypeSignature, emitIsFunctionTypeTest);
+ emitFunctionTypeSignature);
closureClassElement =
addClosureIfNew(closureBuilder, closureClassElement, fieldNames);
@@ -456,19 +451,13 @@ class ContainerBuilder extends CodeEmitterHelper {
boundClosureBuilder.addProperty(operatorSignature, encoding);
}
- void emitIsFunctionTypeTest(FunctionType functionType) {
- String operator = namer.operatorIsType(functionType);
- boundClosureBuilder.addProperty(operator,
- new jsAst.LiteralBool(true));
- }
-
DartType memberType = member.computeType(compiler);
Map<FunctionType, bool> functionTypeChecks =
task.typeTestEmitter.getFunctionTypeChecksOn(memberType);
task.typeTestEmitter.generateFunctionTypeTests(
member, memberType, functionTypeChecks,
- emitFunctionTypeSignature, emitIsFunctionTypeTest);
+ emitFunctionTypeSignature);
closureClassElement =
addClosureIfNew(boundClosureBuilder, closureClassElement, fieldNames);

Powered by Google App Engine
This is Rietveld 408576698