Allows directly entering to VISIBLE_CENTERED state from gesture.

Allows directly entering to VISIBLE_CENTERED state from gesture.

BUG=407292
R=oshima@chromium.org
TEST=athena_unittests

Committed: https://crrev.com/b12b566b9570b8ec05f9a15aaa214e2ae613994f
Cr-Commit-Position: refs/heads/master@{#291915}

[oshima, 2014-08-25 19:32:23]

can you update the description what was the problem?

[Jun Mukai, 2014-08-25 19:39:55]

filed a bug to describe this as crbug.com/407292 and updated BUG= line.

I think this is the expected behavior Alex once showed me...

[oshima, 2014-08-25 20:47:10]

lgtm,

although I wonder if following can make it easier to follow:

* home card state advance in response to gesture,
rather than in response to overview mode change.

* in OnOverviewModeEnter, it moves to bottom if the current state is minimized.

https://codereview.chromium.org/503113002/diff/1/athena/home/home_card_impl.cc
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/503113002/diff/1/athena/home/home_card_impl.c...
athena/home/home_card_impl.cc:612: if (state_ != final_state &&
can exit early if skip if state_ == final_state?

[Jun Mukai, 2014-08-25 21:09:00]

On 2014/08/25 20:47:10, oshima wrote:
> lgtm,
> 
> although I wonder if following can make it easier to follow:
> 
> * home card state advance in response to gesture,
> rather than in response to overview mode change.
> 
> * in OnOverviewModeEnter, it moves to bottom if the current state is
minimized.
> 

Ah, that's clearly better. Done. Thanks for that.

> https://codereview.chromium.org/503113002/diff/1/athena/home/home_card_impl.cc
> File athena/home/home_card_impl.cc (right):
> 
>
https://codereview.chromium.org/503113002/diff/1/athena/home/home_card_impl.c...
> athena/home/home_card_impl.cc:612: if (state_ != final_state &&
> can exit early if skip if state_ == final_state?

[Jun Mukai, 2014-08-25 21:09:05]

https://codereview.chromium.org/503113002/diff/1/athena/home/home_card_impl.cc
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/503113002/diff/1/athena/home/home_card_impl.c...
athena/home/home_card_impl.cc:612: if (state_ != final_state &&
On 2014/08/25 20:47:10, oshima wrote:
> can exit early if skip if state_ == final_state?

That will cause a test failure. Also, the home card has to be laid out by
|layout_manager_| even in that case, because:
- state visible-centered
- slightly swipe down
- release the finger
then the home card has to be repositioned to the full-screen, which is done by
Layout().

[oshima, 2014-08-25 21:20:25]

https://codereview.chromium.org/503113002/diff/1/athena/home/home_card_impl.cc
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/503113002/diff/1/athena/home/home_card_impl.c...
athena/home/home_card_impl.cc:612: if (state_ != final_state &&
On 2014/08/25 21:09:05, Jun Mukai wrote:
> On 2014/08/25 20:47:10, oshima wrote:
> > can exit early if skip if state_ == final_state?
> 
> That will cause a test failure. Also, the home card has to be laid out by
> |layout_manager_| even in that case, because:
> - state visible-centered
> - slightly swipe down
> - release the finger
> then the home card has to be repositioned to the full-screen, which is done by
> Layout().

Acknowledged.

[Jun Mukai, 2014-08-25 21:24:26]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-08-25 21:25:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/503113002/20001

[commit-bot: I haz the power, 2014-08-25 22:16:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-25 22:21:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-25 22:21:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jun Mukai, 2014-08-25 22:24:04]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-08-25 22:26:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/503113002/20001

[commit-bot: I haz the power, 2014-08-26 00:21:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-26 00:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 00:26:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jun Mukai, 2014-08-26 01:04:24]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-08-26 01:09:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/503113002/20001

[commit-bot: I haz the power, 2014-08-26 01:32:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 01:32:06]

Failed to commit the patch.

[Jun Mukai, 2014-08-26 16:13:18]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-08-26 16:14:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/503113002/20001

[commit-bot: I haz the power, 2014-08-26 16:16:35]

Committed patchset #2 (20001) as 9eea9561f1feffd0ab4bf053a41ff5877243cec3

[commit-bot: I haz the power, 2014-09-10 02:43:14]

Patchset 2 (id:??) landed as
https://crrev.com/b12b566b9570b8ec05f9a15aaa214e2ae613994f
Cr-Commit-Position: refs/heads/master@{#291915}